Respected Sir,

We have submitted our code to drupal and its live. need review from you guys so that below warning can be removed.

This project is not covered by Drupal’s security advisory policy.

Project link

https://www.drupal.org/project/imageapi_optimize_way2enjoy

Git instructions

git clone --branch 7.x-1.x https://git.drupal.org/project/imageapi_optimize_way2enjoy.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-imageapi_optim...

Comments

way2enjoy created an issue. See original summary.

way2enjoy’s picture

Assigned: way2enjoy » Unassigned
saesa’s picture

Issue summary: View changes
saesa’s picture

Title: Request for review of code » Image Optimize Way2Enjoy Image Optimizer

Review is for Drupal 7 version or Drupal 8?

way2enjoy’s picture

both version

saesa’s picture

Status: Needs review » Needs work

It appears you are working in the "version7.2" branch in git. You should really be working in a version specific branch. You should delete this branch and create 7.x-1.x branch for Drupal 7 version. You should only have two branches 8.x-1.x and 7.x-1.x. To improve and fix the code look pareview review https://pareview.sh/pareview/https-git.drupal.org-project-imageapi_optim...

way2enjoy’s picture

first of all all platforms creates hell for we developers. someone want svn, someone want git someone want other thing. why cant be a standard practice.
handling GIT is very complicated

saesa’s picture

You must meet the drupal standards to help you check the code.

avpaderno’s picture

Category: Support request » Task
Issue tags: -Module review

We just review a single project, and a single branch. The application is for giving a new role to the user who created the project, not to change status of the project.
Choose the project/branch you want reviewed, and edit the OP to reflect your choice.

avpaderno’s picture

way2enjoy’s picture

Hello we have released version image-optimizer-7.x-1.0 request you to please check once and give secure stamp for our module

rajveergangwar’s picture

Title: Image Optimize Way2Enjoy Image Optimizer » [D8] Image Optimize Way2Enjoy Image Optimizer

adding D8 prefix to title

avpaderno’s picture

The OP still needs to reply to #9 and say which branch needs to be reviewed: Drupal 7 or Drupal 8. The previous reply was both versions, but we just review a single branch/version.

way2enjoy’s picture

Please review version 7

avpaderno’s picture

Title: [D8] Image Optimize Way2Enjoy Image Optimizer » [D7] Image Optimize Way2Enjoy Image Optimizer
Issue summary: View changes
avpaderno’s picture

Status: Needs work » Needs review
avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.