Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
28 Dec 2018 at 09:04 UTC
Updated:
24 Jan 2019 at 16:19 UTC
Jump to comment: Most recent
Comments
Comment #2
way2enjoy commentedComment #3
saesa commentedComment #4
saesa commentedReview is for Drupal 7 version or Drupal 8?
Comment #5
way2enjoy commentedboth version
Comment #6
saesa commentedIt appears you are working in the "version7.2" branch in git. You should really be working in a version specific branch. You should delete this branch and create 7.x-1.x branch for Drupal 7 version. You should only have two branches 8.x-1.x and 7.x-1.x. To improve and fix the code look pareview review https://pareview.sh/pareview/https-git.drupal.org-project-imageapi_optim...
Comment #7
way2enjoy commentedfirst of all all platforms creates hell for we developers. someone want svn, someone want git someone want other thing. why cant be a standard practice.
handling GIT is very complicated
Comment #8
saesa commentedYou must meet the drupal standards to help you check the code.
Comment #9
avpadernoWe just review a single project, and a single branch. The application is for giving a new role to the user who created the project, not to change status of the project.
Choose the project/branch you want reviewed, and edit the OP to reflect your choice.
Comment #10
avpadernoComment #11
way2enjoy commentedHello we have released version image-optimizer-7.x-1.0 request you to please check once and give secure stamp for our module
Comment #12
rajveergangwaradding D8 prefix to title
Comment #13
avpadernoThe OP still needs to reply to #9 and say which branch needs to be reviewed: Drupal 7 or Drupal 8. The previous reply was both versions, but we just review a single branch/version.
Comment #14
way2enjoy commentedPlease review version 7
Comment #15
avpadernoComment #16
avpadernoComment #17
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.