Problem/Motivation

Current Blazy has optional support for Media (entity) via Video Embed Media (VEM). Drupal 8 has Media in core with oEmbed for a while, we can drop VEM. To avoid ramifications, and too many calls to \Drupal::service() due to being optional integration, Blazy must depend on Media.

Proposed resolution

Remaining tasks

Check out the parent issue for more: #2999198: Roadmap for core Media integration

Data model changes

VEM already provides upgrade path: #2997799: Include upgrade path from video_embed_field to oEmbed

Original report by [username]

Somebody here suggested to create a new branch, I forgot the link, sorry, and I agreed after working with core oEmbed for a day today. Can somebody please update [username] part here? Thanks.

CommentFileSizeAuthor
#9 3022743-create-new-branch-8.patch66.94 KBgausarts
#7 3022743-create-new-branch-7.patch65.58 KBgausarts
#6 3022743-create-new-branch-6.patch65.46 KBgausarts
#4 3022743-create-new-branch-4.patch65.5 KBgausarts

Comments

gausarts created an issue. See original summary.

gausarts’s picture

gausarts commented
Issue summary: View changes
gausarts’s picture

gausarts commented
Issue summary: View changes
Parent issue: » #2999198: Roadmap for core Media integration
gausarts’s picture

gausarts commented
Status: Active » Needs review
StatusFileSize
new 3022743-create-new-branch-4.patch65.5 KB

First attempt:

  • Cleaned up CHANGELOG.txt
  • Deprecated plugins which depend on video_embed_media (Blazy Image with Media, Blazy Video). Marked for deletion before Blazy 8.x-2.0.
  • Added temporary workaround to make inner iframe responsive.
  • Autoplay is still not working.

Failing results with images not being loaded:
https://dispatcher.drupalci.org/job/drupal8_contrib_patches/44920/artifa...

gausarts’s picture

gausarts commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
gausarts’s picture

gausarts commented
StatusFileSize
new 3022743-create-new-branch-6.patch65.46 KB

Second attempt. Temporary disabled the known failing test (works local, fails on repo) till proper fix.

gausarts’s picture

gausarts commented
StatusFileSize
new 3022743-create-new-branch-7.patch65.58 KB

Let's see if still fails on this.

gausarts’s picture

gausarts commented

I am out of here, back to drawing room.
At least I see it loading:
https://dispatcher.drupalci.org/job/drupal8_contrib_patches/44926/artifa...

gausarts’s picture

gausarts commented
StatusFileSize
new 3022743-create-new-branch-8.patch66.94 KB

Let's see another attempt.

gausarts’s picture

gausarts commented

That is a beautiful green!
https://dispatcher.drupalci.org/job/drupal8_contrib_patches/44934/artifa...

  • gausarts committed d7e74dc on 8.x-2.x 
    Issue #3022743 by gausarts: Create a new branch for core Media
gausarts’s picture

gausarts commented
Status: Needs review » Fixed

Let's get the ball rolling for wider feedback. Any issue may follow as usual. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.