Problem/Motivation

In order to made this project be covered by the security advisory policy.

Proposed resolution

I would like to suggest & implement some test for this module.

Remaining tasks

Roadmap not declared

User interface changes

not necessary

API changes

not necessary

Data model changes

not necessary

CommentFileSizeAuthor
#9 imagefield_tokens_implement_automation_tests-10.patch17.06 KBysamoylenko
#8 imagefield_tokens_implement_automation_tests-8.patch17.22 KBysamoylenko
#7 imagefield_tokens_implement_automation_tests-7.patch17.22 KBysamoylenko
#6 imagefield_tokens_implement_automation_tests-6.patch17.22 KBysamoylenko
#5 imagefield_tokens_implement_automation_tests-5.patch16.99 KBysamoylenko
#4 imagefield_tokens_implement_automation_tests-4.patch16.67 KBysamoylenko

Comments

AK47 created an issue. See original summary.

ysamoylenko’s picture

ysamoylenko commented

Hello @AK47,

Could you please move your issue to the issues queue here:
https://www.drupal.org/project/issues/imagefield_tokens
?

Because the current module will not be supported more.

akyrylenko’s picture

akyrylenko commented
Project: Image Field Tokens D8 » ImageField Tokens
ysamoylenko’s picture

ysamoylenko commented
Status: Active » Needs review
StatusFileSize
new imagefield_tokens_implement_automation_tests-4.patch16.67 KB

I've implemented automation tests for the module.

Please try to apply the attached patch and run tests.

ysamoylenko’s picture

ysamoylenko commented
StatusFileSize
new imagefield_tokens_implement_automation_tests-5.patch16.99 KB

Added phpunit as require-dev dependency.

ysamoylenko’s picture

ysamoylenko commented
StatusFileSize
new imagefield_tokens_implement_automation_tests-6.patch17.22 KB
ysamoylenko’s picture

ysamoylenko commented
StatusFileSize
new imagefield_tokens_implement_automation_tests-7.patch17.22 KB
ysamoylenko’s picture

ysamoylenko commented
StatusFileSize
new imagefield_tokens_implement_automation_tests-8.patch17.22 KB
ysamoylenko’s picture

ysamoylenko commented
StatusFileSize
new imagefield_tokens_implement_automation_tests-10.patch17.06 KB
IreneV’s picture

IreneV commented
Status: Needs review » Reviewed & tested by the community

Looks great! Thank you!

  • ysamoylenko committed f545afb on 8.x-1.x 
    Issue #3022690 by ysamoylenko, AK47, IreneV: Implement automation tests
ysamoylenko’s picture

ysamoylenko commented
Status: Reviewed & tested by the community » Fixed

Thank you for your report and review. The patch was committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.