Tests are currently failing for PHP 5.5 environments:
PostgreSQL
MySQL

I’ll try to get PHP 5.5 running again locally and see what the problem is.

CommentFileSizeAuthor
#6 3022452-6--fix_views_test_on_php5.patch1002 bytesdrunken monkey
#6 3022452-6--fix_views_test_on_php5--interdiff.txt626 bytesdrunken monkey
#5 3022452-5--fix_views_test_on_php5.patch575 bytesdrunken monkey
#4 3022452-4--failing_tests--potential_fix_1.patch864 bytesdrunken monkey
#3 3022452-3--revert_commit_fb3fb8a2.patch711 bytesdrunken monkey
#3 3022452-3--revert_commit_868b56a7.patch12.21 KBdrunken monkey
#3 3022452-3--revert_commit_868b56a7--except_tests.patch5.44 KBdrunken monkey
#3 3022452-3--revert_commit_868b56a7--tests_only.patch6.77 KBdrunken monkey
#2 3022452-2--revert_last_commits.patch13.36 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 3022452-2--revert_last_commits.patch13.36 KB

First, let’s try reverting the commits from yesterday, to see whether those are the problem. (Seems unlikely, though.)

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
StatusFileSize
new 3022452-3--revert_commit_868b56a7--tests_only.patch6.77 KB
new 3022452-3--revert_commit_868b56a7--except_tests.patch5.44 KB
new 3022452-3--revert_commit_868b56a7.patch12.21 KB
new 3022452-3--revert_commit_fb3fb8a2.patch711 bytes

Oh. Huh. Curious.
Since the tests are also failing with Drupal 8.6, this really seems to indicate our code is at fault. I just don’t know how.
Since getting PHP 5.5 installed locally is quite a hassle, I’ll abuse the test bot a bit …

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
StatusFileSize
new 3022452-4--failing_tests--potential_fix_1.patch864 bytes

OK, so if ViewsTest::testView() is failing the same way even when removing SearchApiEntityOperations and related code, just leaving in the test code from the last commit, then that test code must be the problem, right? As we only added a test method in ViewsTest, it would either have to be the view definition (unlikely, we only add one page) or the additional entity hooks we implemented.

However, I don’t really see anything there that could pose a problem in PHP 5 (5.6 is failing, too.).
Maybe it’s this line?

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Title: Fix failing tests on PHP 5.5 » Fix failing tests on PHP 5
StatusFileSize
new 3022452-5--fix_views_test_on_php5.patch575 bytes

Alright, this should do it – for some reason.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
StatusFileSize
new 3022452-6--fix_views_test_on_php5--interdiff.txt626 bytes
new 3022452-6--fix_views_test_on_php5.patch1002 bytes

Ah. Makes sense. (At least taking the previous fix into account.)

  • drunken monkey committed 6283f7a on 8.x-1.x 
    Issue #3022452 by drunken monkey: Fixed failing tests on PHP 5.
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.