To Recreate the problem:
a. if the user has the Dates filled in, "Repeat" checked, Repeats set to Weekly, and "Every _ weeks" is blank, then after Saving --- the Dates and Repeat values are blanked out.
b. if the user did everything correctly and "Every _ weeks" is filled in, Saves, then all is well. If the user goes back in and sets "Every _ weeks" is blank, then the Dates and Repeat values are blanked out.
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | date-n3022378-16.patch | 1.28 KB | dev11235 |
| #15 | date-n3022378-15.patch | 1.35 KB | dev11235 |
| #14 | date-n3022378-14.patch | 1.36 KB | dev11235 |
| #8 | date-n3022378-8.patch | 1.15 KB | damienmckenna |
| #7 | 3022378-7-repeats-num-weeks-validation.patch | 1.3 KB | dev11235 |
Comments
Comment #2
dev11235 commentedComment #3
dev11235 commentedHere is m attempt at a fix, attached patch file.
Comment #4
dev11235 commentedComment #5
damienmckennaThanks for reporting the bug and the patch, lets see what the testbot says.
Comment #7
dev11235 commentedHmm, err... trying this patch...
Comment #8
damienmckennaThanks for reolling the patch. This fixes the paths, see https://www.drupal.org/patch/create for details.
Comment #10
joelpittet@dev11235 a trick if you're creating the patch from git within the a whole website is use the
--relativeflag. The proper way would be to get the changes on the git repo for the project as @DamienMcKenna mentioned above but if you're on the dev branch already updated thegit diff --relative > name.patchis easier from with the project directory.Also, I've done that type of patch by accident a bunch of times! Still trying to catch myself, probably will do it again.
Comment #11
joelpittet@dev11235, the automated tests are showing a failure when INTERVAL key doesn't exist.
Comment #12
joelpittetLooks like this needs a minor re-roll as well because of some single quote string changes in another patch.
Comment #13
dev11235 commentedThanks for the tips @DamienMcKenna and @joelpittet.
Comment #14
dev11235 commentedOops, this one is more correct
Rerolled. +5 exp. Level up!
Comment #15
dev11235 commentedmore coffee needed
Comment #16
dev11235 commentedugh, not sure why the patch has indentation, fixed indentation
Comment #17
dev11235 commentedComment #18
joelpittetThis looks great, I could see maybe just doing an
!empty()but it would limit other values that "falsey", so thisisset()is probably the way to go.Moving this to a normal issue priority because it's a bug. Minor is more like typos or micro-optimizations.
Comment #20
damienmckennaThanks. Committed.