Move template_preprocess_menu_local_task() and template_preprocess_menu_local_action() to the core/includes/theme.inc [#3021788]

Problem/Motivation

Theme functions template_preprocess_menu_local_task() and template_preprocess_menu_local_action() defined in menu.inc. After deprecations of the menu.inc functions would be logically to store template_* functions in the theme.inc file untill we will find better place or replacement solution for templeate_* functions.

Proposed resolution

Move this preprocess functions to the core/includes/theme.inc

Remaining tasks

patch, discuss, commit

User interface changes

API changes

Data model changes

Release notes snippet

no idea

Comment	File	Size	Author
#15	3021788-15.patch	5.01 KB	Suresh Prabhu Parkala
#15	9.1.x: PHP 7.4 & MySQL 5.7 27,270 pass
#13	3021788-13.patch	5.01 KB	voleger
#13	9.0.x: PHP 7.3 & MySQL 5.7 27,089 pass
#11	3021788-11.patch	5.01 KB	voleger
#11	9.0.x: PHP 7.2 & MySQL 5.7 27,793 pass
#9	3021788-9.patch	4.89 KB	voleger
#9	8.8.x: PHP 7.1 & MySQL 5.7 27,213 pass
#3	3021788-2.patch	5.05 KB	andypost
#3	8.7.x: PHP 7.2 & MySQL 5.5 24,872 pass 8.8.x: PHP 7.1 & MySQL 5.7 Patch Failed to Apply

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

20 December 2018 at 15:15

andypost created an issue. See original summary.

Comment #2

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 20 December 2018 at 15:16

Issue tags:		+Kill includes
Parent issue:		» #2999961: [META] Deprecate contents of menu.inc

Comment #3

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 20 December 2018 at 15:22

Status:

Active

» Needs review

File	Size
3021788-2.patch	5.05 KB
8.7.x: PHP 7.2 & MySQL 5.5 24,872 pass 8.8.x: PHP 7.1 & MySQL 5.7 Patch Failed to Apply

File

Size

3021788-2.patch

5.05 KB

8.7.x:
PHP 7.2 & MySQL 5.5 24,872 pass

8.8.x:
PHP 7.1 & MySQL 5.7 Patch Failed to Apply

Comment #4

voleger

he/his

Ukrainian

Ukraine, Rivne

CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for GOLEMS GABB, Drupal Ukraine Community commented 22 January 2019 at 01:14

Status:

Needs review

» Reviewed & tested by the community

Nice, let's move them.

Comment #5

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Acro Commerce, Thunder commented 23 January 2019 at 15:03

Issue summary:	View changes
Status:	Reviewed & tested by the community	» Needs work

Yeah but their theme hook is defined in drupal_common_theme() which is in theme.inc.

I think rather than doing this piecemeal we should come up with a general rule of how core theme implementations should be registered and the templates and preprocess functions are located.

If we do this patch we're just going to be shifting a lot of code into system.module for all the theme implementations in drupal_common_theme() and that feels wrong.

Comment #6

23 January 2019 at 15:03

Version:

8.7.x-dev

» 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #7

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 26 July 2019 at 20:12

Issue tags:

+Needs frontend framework manager review

Comment #8

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 29 September 2019 at 16:58

Status:

Needs work

» Needs review

@alexpott Except this 2 functions and menu_list_system_menus() all other functions are deprecated in menu.inc

So I think it's fine to move this 2 preprocesses to system module to get rid of include instead of looking for "general" solution

PS: maybe better move them to theme.inc for a while?

Comment #9

voleger

he/his

Ukrainian

Ukraine, Rivne

CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for GOLEMS GABB, Drupal Ukraine Community commented 30 September 2019 at 06:08

File	Size
3021788-9.patch	4.89 KB
8.8.x: PHP 7.1 & MySQL 5.7 27,213 pass

1 file was hidden/shown/deleted

File	Size
3021788-2.patch	5.05 KB
8.7.x: PHP 7.2 & MySQL 5.5 24,872 pass 8.8.x: PHP 7.1 & MySQL 5.7 Patch Failed to Apply

File

Size

3021788-2.patch

5.05 KB

8.7.x:
PHP 7.2 & MySQL 5.5 24,872 pass

8.8.x:
PHP 7.1 & MySQL 5.7 Patch Failed to Apply

Move the template_preprocess_* functions from menu.inc to theme.inc.

Comment #10

30 September 2019 at 06:08

Version:

8.8.x-dev

» 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #11

voleger

he/his

Ukrainian

Ukraine, Rivne

CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for GOLEMS GABB, Drupal Ukraine Community commented 27 November 2019 at 15:36

Version:

8.9.x-dev

» 9.0.x-dev

File	Size
3021788-11.patch	5.01 KB
9.0.x: PHP 7.2 & MySQL 5.7 27,793 pass

1 file was hidden/shown/deleted

File	Size
3021788-9.patch	4.89 KB
8.8.x: PHP 7.1 & MySQL 5.7 27,213 pass

Here the patch for 9.0.x

Comment #12

voleger

he/his

Ukrainian

Ukraine, Rivne

CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for GOLEMS GABB, Drupal Ukraine Community commented 3 March 2020 at 21:12

Title:	Move template_preprocess_menu_local_task() and template_preprocess_menu_local_action() to system module	» Move template_preprocess_menu_local_task() and template_preprocess_menu_local_action() to the core/includes/theme.inc
Issue summary:	View changes
Issue tags:	-Needs frontend framework manager review

Update IS.

Comment #13

voleger

he/his

Ukrainian

Ukraine, Rivne

CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for GOLEMS GABB, Drupal Ukraine Community commented 3 March 2020 at 21:54

File	Size
3021788-13.patch	5.01 KB
9.0.x: PHP 7.3 & MySQL 5.7 27,089 pass

1 file was hidden/shown/deleted

File	Size
3021788-11.patch	5.01 KB
9.0.x: PHP 7.2 & MySQL 5.7 27,793 pass

Just rerolled

Comment #14

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 30 April 2020 at 01:35

Version:	9.0.x-dev	» 9.1.x-dev
Status:	Needs review	» Needs work

This would be a minor-only change. Since 8.9.x and 9.0.x are now in beta, I'm moving this to 9.1.x. Thanks!

Comment #15

Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commented 30 April 2020 at 06:12

Status:

Needs work

» Needs review

File	Size
3021788-15.patch	5.01 KB
9.1.x: PHP 7.4 & MySQL 5.7 27,270 pass

Please review.

Comment #16

daffie CreditAttribution: daffie commented 3 May 2020 at 09:02

Status:

Needs review

» Reviewed & tested by the community

The code changes look good to me.
For me it is RTBC.

Comment #17

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 3 May 2020 at 09:12

Issue tags:

+Needs frontend framework manager review

Comment #18

4 May 2020 at 12:53

lauriii committed 0585f27 on 9.1.x

Issue #3021788 by voleger, andypost, xjm, alexpott: Move...

Comment #19

lauriii

he/him

Finnish

Finland

CreditAttribution: lauriii at Acquia commented 4 May 2020 at 12:57

Status:	Reviewed & tested by the community	» Fixed
Issue tags:	-Needs frontend framework manager review

Confirmed that there aren't any code in the patch that would rely on something that was defined in between the current location and the previous location. There isn't many lines of code in between since these files are loaded after one another in DrupalKernel::loadLegacyIncludes().

Committed 0585f27 and pushed to 9.1.x. Thanks!