jpegoptim config schema declares "progressive" setting incorrectly as boolean, although the processor expects an integer value. This is not a cosmetic issue, as the if condition gets never fulfilled and though you don't get progressive jpegs, when you enable the setting. Fix is simple, patch to follow

CommentFileSizeAuthor
#5 3021534-5.patch1.5 KBinit90
#2 3021534-2.patch489 bytesagoradesign

Comments

agoradesign created an issue. See original summary.

agoradesign’s picture

agoradesign commented
Status: Active » Needs review
StatusFileSize
new 3021534-2.patch489 bytes
spleshka’s picture

spleshka
he/him
Primary language English
Location UAE
commented
Status: Needs review » Reviewed & tested by the community

Run into the same issue today, changing the field type has fixed the issue.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3021534-2.patch, failed testing. View results

init90’s picture

init90
Location Ukraine
commented
Status: Needs work » Needs review
StatusFileSize
new 3021534-5.patch1.5 KB

I've also encountered such a problem and the patch help me.

I'm attaching a patch which also contains an update for existing configurations.

Status: Needs review » Needs work

The last submitted patch, 5: 3021534-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

steven jones’s picture

steven jones commented
Component: Code » JpegOptim Processor
Status: Needs work » Fixed

Thanks so much for the patches!

  • Steven Jones committed 3fc2bfc on 8.x-1.x authored by init90 
    Issue #3021534 by agoradesign, init90: jpegoptim config schema declares...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.