Closed (fixed)
Project:
Feeds
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
17 Dec 2018 at 11:32 UTC
Updated:
10 Jan 2019 at 20:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
thallesFollow the patch!
Comment #3
thallesComment #4
megachrizNice change. I have a few remarks.
The contructor parameters and the class properties need to be documented.
Now that we are at it, we might as well replace the constant
REQUEST_TIMEwhich is deprecated since Drupal 8.3.See https://api.drupal.org/api/drupal/core%21includes%21bootstrap.inc/consta...
Comment #5
thallesThanks for helping me! :)
Follow the patch!
Comment #6
megachrizIt looks like that patch is meant for the Google Analytics module. ;)
Comment #7
thalles:)
Sorry! I was in the wrong directory at the time of generating the patch.
Follow!
Comment #8
megachrizSorry, I forgot that the entity.query service is also deprecated. See https://www.drupal.org/node/2849874
I think that instead we need to pass the entity type manager here.
Comment #9
thallesFollow the patch!
Comment #10
megachrizI was about to commit this, but I noticed that classes were referenced instead of interfaces. It is a best practice to require interfaces in methods instead of classes if available (a prerequisite is of course that the interface has the methods that you want to call on the object).
Also changed:
::create().Comment #11
thallesThanks!
Works for me!
Comment #13
megachrizThanks for checking, @thalles! Committed #10.
Comment #14
thallesMuito bom trabalho com você!