Problem/Motivation

Dispatch event, when handled the post request ensures the replication is complete.

Proposed resolution

Update event dispatching

CommentFileSizeAuthor
#8 interdiff.txt2.06 KBjeqq
#8 3020496-8.patch4.89 KBjeqq
#6 interdiff.txt3.37 KBjeqq
#6 3020496-5.patch4.91 KBjeqq
#2 3020496-2.patch4.89 KBaxicdv

Comments

axicdv created an issue. See original summary.

axicdv’s picture

axicdv commented
Status: Active » Needs review
StatusFileSize
new 3020496-2.patch4.89 KB
axicdv’s picture

axicdv commented
Title: Better dispatch events » Relaxed. Better dispatch events
l0ke’s picture

l0ke
Primary language English
Location Ukraine
commented
Status: Needs review » Reviewed & tested by the community

Tests are currently failing and it is hard to add a proper test on event dispatching.
My proposition is to create follow-ups and track them separately

  1. Fix current tests
  2. Cover event dispatching with tests

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3020496-2.patch, failed testing. View results

jeqq’s picture

jeqq commented
Status: Needs work » Needs review
StatusFileSize
new 3020496-5.patch4.91 KB
new interdiff.txt3.37 KB

I've done some refactoring.

Regarding the failing tests with the branch, they look to be related to a core issue, we use a patch to test with Travis on Github, you can see there tests are green: https://travis-ci.org/relaxedws/drupal-relaxed/builds/474832080

Status: Needs review » Needs work

The last submitted patch, 6: 3020496-5.patch, failed testing. View results

jeqq’s picture

jeqq commented
StatusFileSize
new 3020496-8.patch4.89 KB
new interdiff.txt2.06 KB

I've forgotten to rename the file.

jeqq’s picture

jeqq commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 8: 3020496-8.patch, failed testing. View results

  • jeqq committed e1f358e on 8.x-1.x authored by axicdv 
    Issue #3020496 by jeqq, axicdv, l0ke: Relaxed. Better dispatch events
jeqq’s picture

jeqq commented
Status: Needs work » Fixed

The followup for adding a test: #3023839: Followup: Add a test for REPLICATION_ENSURE_FULL_COMMIT event

  • jeqq committed 7fcf2e4 on 8.x-2.x authored by axicdv 
    Issue #3020496 by jeqq, axicdv, l0ke: Relaxed. Better dispatch events

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.