Module implements a Drupal Commerce payment method, to embed the payment services provided by Webpay.by payment gateway.

Project link

https://www.drupal.org/project/commerce_webpay_by

Git instructions

git clone --branch 8.x-1.x https://git.drupal.org/project/commerce_webpay_by.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-commerce_webpa...

CommentFileSizeAuthor
webpay_config.png48.73 KBawd studio

Comments

AWD Studio created an issue. See original summary.

avpaderno’s picture

Issue summary: View changes

Thank you for your contribution!
I am adding the PAReview checklist link. If you haven't done it yet, please check the reported issues, and fix the code as indicated. Don't pay attention to the false positives the checklist could contain.

Next, the reviewers will check the project code, and report here what needs to be changed.

avpaderno’s picture

Status: Needs review » Needs work

PAReview reports formatting needs to be fixed and some variables that aren't initialized before beging used. Also, master should not be used for code; instead, a branch like 8.x-1.x should be used.

awd studio’s picture

Issue summary: View changes

Thanks a lot for review!
I've fixed mostly everything from the list, switched to the correct branch and replaced the PAReview checklist link with it.
Looking forward to the next review.

awd studio’s picture

Status: Needs work » Needs review
saesa’s picture

Status: Needs review » Needs work

Review of the 8.x-1.x branch (commit 4d6c038):

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...w_temp/src/Plugin/Commerce/PaymentGateway/WebpayByPaymentGateway.php
    --------------------------------------------------------------------------
    FOUND 3 ERRORS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     29 | ERROR | [ ] Missing short description in doc comment
     47 | ERROR | [ ] Doc comment short description must start with a capital
        |       |     letter
     47 | ERROR | [x] Doc comment short description must end with a full stop
    --------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------
    
    Time: 1.35 secs; Memory: 4Mb
    
awd studio’s picture

Hi @saesa! Thanks for your review!
Those "errors" are about the "@inheritdoc" comment blocks, which are pretty usual for Drupal-modules (and the global practices).
Must I fill them with the parent description?

avpaderno’s picture

If you are using {@inheritdoc} to have the same documentation comment the parent class uses, that is correct. Consider what reported a false positive.

awd studio’s picture

Status: Needs work » Needs review

Ok, I've found the mistake (It's mine). I used inheritdoc comments without braces. My bad!

Fixed and added new commits. The last is (a2e8b77e), it made PAReview clean (https://pareview.sh/pareview/https-git.drupal.org-project-commerce_webpa...).

avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

avpaderno’s picture

awd studio’s picture

Great thanks!
I'll try to find more time for community.
Happy holidays!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.