Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
13 Dec 2018 at 17:48 UTC
Updated:
12 Jan 2019 at 14:34 UTC
Jump to comment: Most recent
Comments
Comment #2
avpadernoThank you for your contribution!
I am adding the PAReview checklist link. If you haven't done it yet, please check the reported issues, and fix the code as indicated. Don't pay attention to the false positives the checklist could contain.
Next, the reviewers will check the project code, and report here what needs to be changed.
Comment #3
avpadernoPAReview reports formatting needs to be fixed and some variables that aren't initialized before beging used. Also, master should not be used for code; instead, a branch like 8.x-1.x should be used.
Comment #4
awd studio commentedThanks a lot for review!
I've fixed mostly everything from the list, switched to the correct branch and replaced the PAReview checklist link with it.
Looking forward to the next review.
Comment #5
awd studio commentedComment #6
saesa commentedReview of the 8.x-1.x branch (commit 4d6c038):
Comment #7
awd studio commentedHi @saesa! Thanks for your review!
Those "errors" are about the "@inheritdoc" comment blocks, which are pretty usual for Drupal-modules (and the global practices).
Must I fill them with the parent description?
Comment #8
avpadernoIf you are using
{@inheritdoc}to have the same documentation comment the parent class uses, that is correct. Consider what reported a false positive.Comment #9
awd studio commentedOk, I've found the mistake (It's mine). I used inheritdoc comments without braces. My bad!
Fixed and added new commits. The last is (a2e8b77e), it made PAReview clean (https://pareview.sh/pareview/https-git.drupal.org-project-commerce_webpa...).
Comment #10
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #11
avpadernoComment #12
awd studio commentedGreat thanks!
I'll try to find more time for community.
Happy holidays!