Closed (fixed)
Project:
Sortableviews
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
13 Dec 2018 at 11:28 UTC
Updated:
17 Jul 2026 at 12:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
anybodyYeah that's a really nice idea, maybe the classes are already set by SortableJS and we just need some CSS (that should be as universal as possible). Maybe someone could create a MR?
Comment #3
anybodyComment #6
enomo103 commentedComment #8
kieran.cottNice one Takuya - MR 18 looks like it'll work, though at the moment it looks like the pipelines are failing.
Since we're modifying this part of the code anyway, it might be a good opportunity to get the pipelines to pass.
I’ve prepared a couple of small follow-up fixes to get the pipeline green: replacing the deprecated Request::get() usage while preserving the existing parameter lookup behaviour, updating the PHPUnit 11 expectations/data providers, and fixing the CSS property order warning.
Comment #9
anybodyThe JS part looks good, but this seems to contain a lot of unrelated changes. Please only add the related parts here!
See #3584702: Fix code style (cspell, phpstan) and phpunit for other tasks.
Comment #10
kieran.cottGot it, I've reverted the MR to its original state in comment #5, and will address the pipeline failures in issue 3584702 instead.
Comment #11
kieran.cottComment #12
anybodyThanks, that LGTM, did you test it manually?
Comment #13
kieran.cottI have, yes - looks good!
Comment #14
kieran.cottComment #15
anybodyThanks, yes. Confirming RTBC.
Comment #17
dieterholvoet commentedWorks well, thanks!