It's a very good alternative of draggable views module,

One suggestion, its better if we can Highlight row on till sorted weights are not saved.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

visabhishek created an issue. See original summary.

anybody’s picture

Issue tags: +Novice

Yeah that's a really nice idea, maybe the classes are already set by SortableJS and we just need some CSS (that should be as universal as possible). Maybe someone could create a MR?

anybody’s picture

Title: Heighlight row on unsaved state » Highlight row on unsaved state

enomo103 made their first commit to this issue’s fork.

enomo103’s picture

Status: Active » Needs review

kieran.cott made their first commit to this issue’s fork.

kieran.cott’s picture

Nice one Takuya - MR 18 looks like it'll work, though at the moment it looks like the pipelines are failing.

Since we're modifying this part of the code anyway, it might be a good opportunity to get the pipelines to pass.

I’ve prepared a couple of small follow-up fixes to get the pipeline green: replacing the deprecated Request::get() usage while preserving the existing parameter lookup behaviour, updating the PHPUnit 11 expectations/data providers, and fixing the CSS property order warning.

anybody’s picture

Status: Needs review » Needs work

The JS part looks good, but this seems to contain a lot of unrelated changes. Please only add the related parts here!

See #3584702: Fix code style (cspell, phpstan) and phpunit for other tasks.

kieran.cott’s picture

Got it, I've reverted the MR to its original state in comment #5, and will address the pipeline failures in issue 3584702 instead.

kieran.cott’s picture

Status: Needs work » Needs review
anybody’s picture

Thanks, that LGTM, did you test it manually?

kieran.cott’s picture

StatusFileSize
new73.96 KB

I have, yes - looks good!

kieran.cott’s picture

Status: Needs review » Reviewed & tested by the community
anybody’s picture

Thanks, yes. Confirming RTBC.

dieterholvoet made their first commit to this issue’s fork.

dieterholvoet’s picture

Status: Reviewed & tested by the community » Fixed

Works well, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.