I tried to remove admin_menu from devshop in favor of navbar, and it blew up in my face.

The problem is, hosting.module doesn't require admin_menu, but it does try to save a permission from admin menu, which does not exist if the module doesn't exist.

in

hosting_add_permissions()

There is no check on the permissions thing before it tries to set it.

I don't know, this does seem wrong... I think we can check it with this:

CommentFileSizeAuthor
#3 3020169-permission-check.patch834 bytesjon pugh

Comments

Jon Pugh created an issue. See original summary.

  • Jon Pugh committed 4ceaa61 on 3020169-permission-check
    Issue #3020169: Installing hosting.module without admin_menu breaks...
jon pugh’s picture

StatusFileSize
new834 bytes
jon pugh’s picture

Status: Active » Needs review
jon pugh’s picture

Helmo, Colan, Ergonlogic?

jon pugh’s picture

Issue tags: +devshop patches
jon pugh’s picture

Status: Needs review » Reviewed & tested by the community

This has been in devshop since it was created.

Marking it tested.

jon pugh’s picture

Status: Reviewed & tested by the community » Fixed

  • Jon Pugh committed a6f3810 on 7.x-3.x
    Issue #3020169: Installing hosting.module without admin_menu breaks...

  • Jon Pugh committed 4ceaa61 on 7.x-3.x
    Issue #3020169: Installing hosting.module without admin_menu breaks...

  • Jon Pugh committed 2025e32 on 7.x-3.x
    Issue #3020169: Refactoring the fix to properly remove non-existant...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

ergonlogic’s picture

Assigned: jon pugh » ergonlogic
Status: Closed (fixed) » Needs work

This has broken the way that Hosting Features assign permissions. Now only aegir admins get any permissions.

  • ergonlogic committed 6ca8200 on 7.x-3.x
    Issue #3020169: Fix handling of permissions defined in Hosting Features.
    
ergonlogic’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.