Selection not properly updated on multi-page view when using Ctrl+Shift

We also encountered this bug

I tried pressing ctrl-shift on a VBO view and on a core bulk operations view, both with tableselect.. nothing happened.
I tried using tab and space to make selection - worked on both.

Can you tell me more about this selection method? I'm using a Mac and Chrome..

Hi Graber, usually to select multiple entries in a tableselect, I check the first one I want to be selected, then I scroll to the last item I want selected and keep shift pressed while clicking in the checkbox. All rows between the first and last one are selected.
It seems that VBO does only consider first and last as checked. I'm on Windows and Firefox/Chrome.

You're right.. I have no idea how to handle this at the moment, just that it has to be done in js/frontUi.js some similar way the tableselect select all checkbox is handled.

What's with the ctrl in description then when you need to hold shift only?

I'm not sure about the ctrl mentioned in the description, but I think it's related to the same underlying issue.
Maybe @jaapjan could enlight this matter ?

Here is a patch for using same behavior as the tableSelect.
I also created a patch for the current 8.x-3.13 version of the module.

Fixing an issue with "Select / deselect all results in this view (all pages, ... total)" checkbox

This patch also fixes issues with multi-selection for the 4.x branch.

Bumping version for this.

Rerolled patch for 4.1 branch

Rerolled patch for 4.2 branch.
Can someone test this patch so we can RTBC ?
Or else I'm doomed to do rerolls for eternity ;)

Yes, yes, I was afraid of this as the last JS improvement broke things and had to fix myself as of course the commit author didn't treat that as a priority. Luckily we have JS tests on now.

I'll commit this when I see it's sufficiently tested, don't want additional hotfixing after the next release.

Okay thanks, sorry I did not mean to put the rush on you. Thank you for all your work on this module.
I will help as much as possible, tell me if anything has to be changed on this patch.
I see the tests failed, I'll take a look on it

I know JS tests can be tricky so a few hints:

• https://github.com/graber-1/ddev-drupal - working ddev stack where you just install VBO and can run phpunit and FunctionalJavascript will work out of the box.
• Use Drupal\FunctionalJavascriptTests\WebDriverTestBase::createScreenshot() ($this->createScreenshot()), wherever needed - it helps a lot.

I think I came up with a more simple solution, described it there. In short we don't have to check what key the user pressed but just check state of all checkboxes in the view. It should be a very small change this way.

Actually I just found out that after updating Drupal core from 10.0.9 to 10.1.0 even a normal click selection (not just in a table display but unformatted list as well) is not reflected in the vbo form wrapper (which is now at the bottom of the view only).

After checking one or more items, the buttons are enabled (and vbo will correctly execute on them) but "No items selected" is not updated.

Should I open another issue or should this be solved here?

When using core's "Bulk update" views field instead of "Views bulk operations", the selection is updated in the UI instead:

This comment in the related issue might be relevant and the cause of my bug:

Please test this one, it's using my last concept.

The good thing about it is that it should be fool proof in all cases, every change checks the entire page state.
The bad thing is a bit worse performance as we send more data and do more checking in the frontend but it shouldn't be an issue.

Also contains a bit of cleanup.

Please test in the following areas as there may be regressions:
- multiple VBO views on the same page
- multiple tables (was it aggregation?)

#22 does fix the shift+click issue, and the selection logic is much better than before.

However, I noticed that the VBO count part that says "Selected # items" doesn't update properly after clicking a "select all" checkbox. I have a view with rows grouped by a field, so there are multiple "select all" checkboxes, one for each grouping. Still, I think I could reproduce this with only a single "select all".

Example with 5 rows:

1. Click a checkbox on a row (selected 1 item)
2. Click the "select all" checkbox (selected 1 item, WRONG: should be 5)
3. Click a checkbox on a row to deselect (selected 4 items)
4. Click the same to select it again (selected 5 items)
5. Click the "select all" checkbox (none selected, VBO is hidden)
6. Click the "select all" checkbox (selected 0 items, WRONG: should be 5)

Note that each time I say to click "select all", I'm talking about the select all checkbox on the table, not the "Select / deselect all results (all pages, # total)" shown by the VBO popup.

Thank you for your testing @solideogloria, I fixed the mentioned issue, please retest, hopefully now all is ok.

This should do the trick. Please retest.

Patch #26 fixes the issues I mentioned in #23.

Thank you.

I just tested the patch as well. I can confirm it works! Thanks, @Graber.