This is the issue for the other 8.5 test fail.

CommentFileSizeAuthor
#13 3019389-13.patch2.16 KBwim leers
#13 interdiff.txt781 byteswim leers
#4 3019389-4.patch2.07 KBwim leers
#4 interdiff.txt1.44 KBwim leers
#2 3019389-2.patch933 byteswim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 3019389-2.patch933 bytes

This fixes ::testRelationships(), not yet ::testGet().

Status: Needs review » Needs work

The last submitted patch, 2: 3019389-2.patch, failed testing. View results

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.44 KB
new 3019389-4.patch2.07 KB

And this fixes ::testGet().

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Green! Queueing 8.5 and 8.7 tests too. Committing after those come back green.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Error: Class 'Drupal\Core\Cache\MemoryCache\MemoryCache' not found this is now failing because of #3014232: [regression] ResourceTypeRepository is significantly slower in JSON:API 2, becomes noticeable when handling hundreds of interlinked resources 😱 😫 😡

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: MediaTest fails on 8.7 since #2956368 » [PP-1] MediaTest fails on 8.7 since #2956368
Status: Reviewed & tested by the community » Postponed

Postponed on #3014232: [regression] ResourceTypeRepository is significantly slower in JSON:API 2, becomes noticeable when handling hundreds of interlinked resources.

gabesullice’s picture

gabesullice
Primary language English
commented
Status: Postponed » Needs review

Retesting on 8.5/6/7

gabesullice’s picture

gabesullice
Primary language English
commented
Title: [PP-1] MediaTest fails on 8.7 since #2956368 » MediaTest fails on 8.7 since #2956368

This patch has its own 8.5 related failure:

Testing Drupal\Tests\jsonapi\Functional\MediaTest
.F.....

Time: 1.33 minutes, Memory: 4.00MB

There was 1 failure:

1) Drupal\Tests\jsonapi\Functional\MediaTest::testGetIndividual
The document members did not match the expected values. Missing: [ meta ].

8.5 has another failure on HEAD which means that it won't pass entirely, but we can still address this one so that it can be RTBC when the other bug is resolved. Therefore, I'm removing the [PP-1] status until we do so.

gabesullice’s picture

gabesullice
Primary language English
commented
Issue summary: View changes
Related issues: +#3019506: UserTest::testRelated() fails on Drupal 8.5 because no $reason is given in the Access Denied response
gabesullice’s picture

gabesullice
Primary language English
commented

@Wim Leers, if you get a chance to work on this and fix the issue in #9, I would commit this patch even if #3019506 is not yet fixed. Then we'll only have one issue left to resolve to unbreak HEAD. This one affects 8.5, 8.6, and 8.7 while the other only affects 8.5 (AFIACT, at the moment).

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work

#3019506: UserTest::testRelated() fails on Drupal 8.5 because no $reason is given in the Access Denied response just landed.

This patch has its own 8.5 related failure:

Reproduced.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt781 bytes
new 3019389-13.patch2.16 KB

The failure on 8.5 is introduced by #3, because it was stupidly and obviously wrong! 😭 I copy/pasted it without updating the array keys.

The lack of multi-minor automated patch testing is understandable from a cost PoV, but it's clearly causing havoc. At least on-commit testing against 8.5 is now working again. (But setting that up at https://www.drupal.org/node/2723491/qa confused other things again, I pinged https://www.drupal.org/u/mixologic about that.)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Despite #3019506-7: UserTest::testRelated() fails on Drupal 8.5 because no $reason is given in the Access Denied response being green (on PHP 7), the first branch-level test run against 8.5 failed (on PHP 5). Apparently JSON:API + Drupal 8.5 fails on PHP 5, in one really obscure case. But that's perhaps not a bad thing in the end, since PHP 5 support has ended…

Green on 8.6 and 8.7, and green on 8.5 + PHP 7. Let's do this.

  • Wim Leers committed 610d466 on 8.x-2.x 
    Issue #3019389 by Wim Leers: MediaTest fails on 8.7 since #2956368
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

  • gabesullice committed a9156da on 8.x-1.x 
    Issue #3021080 by gabesullice: Backport #3019389: MediaTest fails on 8.7...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.