Tests using WebTestBase should be changed to use BrowserTestBase. See #2847678: Deprecate WebTestBase and its required classes in favour of BrowserTestBase.

Subtasks:

Needs Review:

Fixed:

CommentFileSizeAuthor
#29 entity-browser-3018976-29.patch98.48 KBoknate
#22 entity-browser-3018976-22.patch51.63 KBoknate
#16 entity-browser-3018976-16.patch77.9 KBoknate
#14 entity-browser-3018976-14.patch111.12 KBoknate
#13 entity-browser-3018976-13.patch80.23 KBoknate
#12 entity-browser-3018976-12.patch133.38 KBoknate
#11 interdiff-10-11.txt1.02 KBoknate
#11 entity-browser-3018976-11.patch129.46 KBoknate
#10 interdiff-9-10.txt32.76 KBoknate
#10 entity-browser-3018976-10.patch127.21 KBoknate
#9 entity-browser-3018976-9.patch116.41 KBoknate
#8 entity-browser-3018976-8.patch118.73 KBoknate
#4 entity-browser-browsertestbase-3018976-4.patch43.01 KBoknate
#3 entity-browser-browsertestbase-3018976-3.patch42.97 KBoknate
#2 entity-browser-browsertestbase-3018976-2.patch33.84 KBoknate

Comments

oknate created an issue. See original summary.

oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new entity-browser-browsertestbase-3018976-2.patch33.84 KB

Initial patch, didn't test locally, just changed classes and changed many deprecated functions.

oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new entity-browser-browsertestbase-3018976-3.patch42.97 KB
oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new entity-browser-browsertestbase-3018976-4.patch43.01 KB
oknate’s picture

oknate
Location Greater New York City Area
commented
Related issues: +#3020353: Test needs update due to change in Drupal 8.7
oknate’s picture

oknate
Location Greater New York City Area
commented
Related issues: +#3020449: ImageFieldTest::testImageFieldSettings fails on Drupal 8.7
oknate’s picture

oknate
Location Greater New York City Area
commented

I'm having trouble with converting some of the calls to $this->drupalPostAjaxForm(). Anyone else want to update my patch?

oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new entity-browser-3018976-8.patch118.73 KB

I started working on this again. I have drupalci_testbot set up locally. This patch is a work in progress. Since I'll probably have to take a break from this, I wanted to post my work in progress.

oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new entity-browser-3018976-9.patch116.41 KB

Working on MultistepDisplayTest

oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new entity-browser-3018976-10.patch127.21 KB
new interdiff-9-10.txt32.76 KB

working on file uploads, adding TestFileCreationTrait where drupalGetTestFiles used.

oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new entity-browser-3018976-11.patch129.46 KB
new interdiff-10-11.txt1.02 KB
oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new entity-browser-3018976-12.patch133.38 KB
oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new entity-browser-3018976-13.patch80.23 KB

Removing coding standard changes I accidentally included from another issue.

oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new entity-browser-3018976-14.patch111.12 KB

Same as 13, trying to just remove coding standard changes from other issue.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs work

Pretty sure this needs a pretty big reroll now :)

BTW, I would recommend to split such a task up, first just move all tests to phpunit, with minimally required changes and keeping all the old deprecated asserts and so on. They will most likely not be removed in D9 and we are about to remove the explicit deprecation marker on them for now: #3031580: Undeprecate \Drupal\FunctionalTests\AssertLegacyTrait and \Drupal\KernelTests\AssertLegacyTrait in Drupal 8.

That keeps these conversions reviewable. Not quite sure what makes more sense now, as I expect some massive conflicts on the admin UI tests.. maybe keep what still applies but don't spend too much on the admin UI tests and just re-move them from the old place with minimal changes.

The fake drupalPostAjaxForm() is gone, everything that uses that either needs to be converted to javascript tests or rewritten in a way to avoid that. Sometimes it doesn't actually need JS, I used it quite often to submit form elements that weren't a button or had no unique label, that's actually often possible now through the mink API.

oknate’s picture

oknate
Location Greater New York City Area
commented
StatusFileSize
new entity-browser-3018976-16.patch77.9 KB

Reroll. There were massive conflicts on two of the tests. For those ones, I just kept what's in head, and will have to redo some work.

Thanks for the info about possibly undeprecating AssertLegacyTrait, if that is merged in, it will make this issue less urgent. I'll keep plugging away at it, and I'll see what I can do to break it up. I think a few of the smaller ones are done.

oknate’s picture

oknate
Location Greater New York City Area
commented
Title: Convert tests using WebTestBase to BrowserTestBase » [META] Convert tests using WebTestBase to BrowserTestBase
Issue summary: View changes
Status: Needs work » Active
Related issues: -#3020353: Test needs update due to change in Drupal 8.7, -#3020449: ImageFieldTest::testImageFieldSettings fails on Drupal 8.7 +#3033526: Update ConfigUITest to WebDriverTestBase from WebTestBase
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Status: Active » Needs review
StatusFileSize
new entity-browser-3018976-22.patch51.63 KB

I moved some of the tests to separate issues. The ones that remain all extend a class I'm renaming. I may break those up too by adding another base ticket and then create subtickets for each one. Or else I might just leave the remaining ones here. We'll see how badly it fails on the testbot.

oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 22: entity-browser-3018976-22.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

primsi’s picture

primsi commented
Issue tags: +drupalmountaincamp
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes

Adding #3040286: PluginsTest failing on 8.6.11, The need to update PluginsTest is more critical now.

oknate’s picture

oknate
Location Greater New York City Area
commented
Status: Needs work » Needs review
StatusFileSize
new entity-browser-3018976-29.patch98.48 KB

This patch updates the classes extending EntityBrowserJavascriptTestBase to a new class EntityBrowserWebDriverTestBase.

oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented

Updated #3040745: Convert MultistepDisplayTest from WebTestBase to BrowserTestBase, that one's ready for review now.

oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes

Moving patch 29 to #3040770: Update test classes extending EntityBrowserJavascriptTestBase.

That way, this ticket is only a META ticket. I think it will keep it clearer what needs review.

oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
oknate’s picture

oknate
Location Greater New York City Area
commented
oknate’s picture

oknate
Location Greater New York City Area
commented
oknate’s picture

oknate
Location Greater New York City Area
commented

Rerolled #3040770: Update test classes extending EntityBrowserJavascriptTestBase

oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
commented
Issue summary: View changes

#3038131: Convert InlineEntityIntegrationTest from WebTestBase to WebDriverTestBase is fixed! That was the last one (within entity_browser module) that used the old base class.

oknate’s picture

oknate
Location Greater New York City Area
commented
Status: Needs review » Fixed

I'm going to go ahead and mark this as fixed. There are two issues left, but they are in other contrib modules.

oknate’s picture

oknate
Location Greater New York City Area
commented
Status: Fixed » Closed (fixed)