PHP 7.0 has reached EOL a few days ago (2018. 12. 03.) and PHP 5.6 follows it soon.

Although 7.1 is going to have security support for another year (2019 December 1), we probably should update requirements to 7.2 as it is going to have active support until 2019 November 30.

Edit:

  • As discussed in the comments, we should only go from 7.0 to 7.1 instead of directly jumping to 7.2.
  • As PHP5.6 has still official security support, we should support that as well.
  • Furthermore, we should look into Drupal core and Drush versions and set a minimum requirement for the oldest ones that fully support 7.1

Comments

mhavelant created an issue. See original summary.

andrewbelcher’s picture

andrewbelcher commented

A requirement on 7 makes sense (if we don't already have it), but unless we require something new in a later minor version I don't think we should arbitrarily update the requirement as that will just cause people headaches.

Definitely shouldn't go to 7.2 as 7.1 is still actively supported and it would be unreasonable to disallow using a supported version unless we need a feature from a later version.

Our requirement is about compatibily, not about the security of php itself, so I don't think we should be worrying about tracking the latest/supported versions, only if there are things we need for compatibility.

baluertl’s picture

baluertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
commented
Assigned: Unassigned » lbesenyei
james.williams’s picture

james.williams
Location Coventry, UK
commented

I'd definitely agree with Andrew there. Keeping the project as inclusive as it can be should be a priority, that is one of the Drupal community's key values. (Though, yes, without compromising on security too much.) Personally, I still believe the project should just match Drupal core's own platform requirements, rather than trying to set a higher bar. But I don't think other maintainers share my opinion. The project could still strongly advise users of any necessary security concerns about that, but still have fully compatible code so it can still be installed & used in its entirety.

mhavelant’s picture

mhavelant commented
Title: Update minimum PHP requirements to 7.2 » Update minimum PHP7 requirements to PHP7.1
Issue summary: View changes
baluertl’s picture

baluertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
commented
Status: Active » Fixed

A pair of new versions (8.x-2.0-alpha5 and 8.x-1.0-alpha17) released with updated PHP version requirement in gdpr.info.yml file. Currently set to PHP 5.6, soon to be updated to 7.1 since PHP 5.6 security support will end on 31 Dec 2018. Thanks lbesenyei the quick work!

james.williams’s picture

james.williams
Location Coventry, UK
commented
Related issues: +#2975842: syntax error, unexpected '[' , +#2967557: Make PHP 5.4 a requirement for the D7 version

Adding related issues, since this issue pretty much bypassed previous discussion :-/

lbesenyei’s picture

lbesenyei commented

The code has been updated to be compatible with PHP 7.2.
The info files have been updated to require PHP 5.6, this will be updated as PHP 5.6 reaches its end of life.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.