Install fails if module Menu Trail by Path is installed

Hey, you are correct, these two modules do cause fatal error and break a site. Problem is they both alter "menu.active_trail" service by applying own class and adding different arguments.

Here is a quick fix that solves fatal error and gives Menu Trail by Path ability to manipulate Menus and warns users that Context Menu reactions are handled by Menu Trail by Path module instead of Context module. (Added two checks - one in ContextServiceProvider and one in .module.)

Corrected a typo.

Reviewed patch in #4, tested and works as expected.

Tested patch against a Drupal GovCMS 8 distribution and works as advertised,

Thanks!

Will this patch be rolled out soon?

A number of sites are waiting for it to become part of the stable release.

I think this is being held back by the fact that there is a hardcoded reference to another module. If this patch would go through, I think it should be on a more general level, e.g.: "If you are using a different menu service provider, this may not work", and the purpose of this patch should be to catch any such examples, not just one specific module.

How exactly to implement this, is a different question. We would need to somehow figure out if any of the installed modules overrides this, and then show this warning (dynamic - not with hardcoded values to only 1 module)

I agree with @maticb.
Let's see if we find a better solution.

Hello @all,
here is a new patch.
I don't know if the best approach but what I did is that I verified if the core service were changed before. If so, it will display a warning like patch #4 telling the user that this reaction will not work.

Thanks.

Patch re-rolled.

Fix code standard.

Fixed in dev branch.

cross-posting #3170929: ContainerNotInitializedException: \Drupal::$container is not initialized yet.

looks like this change is causing a fatal error during bootstrap