Problem/Motivation

There are currently 66 coding standard violations in HEAD, it would be great to remove those.

Proposed resolution

Fix all CS violations.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#7 interdiff.txt599 byteswim leers
#5 3018270-5.patch26.41 KBmarcoscano
#5 interdiff-3-5.txt740 bytesmarcoscano
#3 3018270-3.patch25.69 KBmarcoscano

Comments

marcoscano created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Thanks! 🙏

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
commented
Assigned: marcoscano » Unassigned
Status: Active » Needs review
StatusFileSize
new 3018270-3.patch25.69 KB

There are still a couple that I think we can live with, because it involves some refactoring I'm not sure about (and might involve BC considerations).

Status: Needs review » Needs work

The last submitted patch, 3: 3018270-3.patch, failed testing. View results

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-3-5.txt740 bytes
new 3018270-5.patch26.41 KB

  • Wim Leers committed 4826d64 on 8.x-1.x authored by marcoscano 
    Issue #3018270 by marcoscano, Wim Leers: Fix CS violations in HEAD
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Fixed
StatusFileSize
new interdiff.txt599 bytes 
+++ b/src/Form/EntityEmbedDialog.php
@@ -783,8 +798,7 @@ class EntityEmbedDialog extends FormBase {
+   * Returns the allowed d display plugins given an embed button and an entity.

s/d display/display/

Fixed on commit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.