• Current dev requires 8.4 core
    drupal:system (>=8.4.0)
  • but the tests introduced in 2328659 use WebDriverTestBase (i.e Drupal\FunctionalJavascriptTests\WebDriverTestBase)
  • and WebDriverTestBase was introduced in 8.6 - see change record 2945059.
  • with core 8.5.8 I get a WSOD running the tests - log message:
    Class 'Drupal\FunctionalJavascriptTests\WebDriverTestBase' not found
in /modules/contrib/entity_embed/tests/src/FunctionalJavascript/EntityEmbedTestBase.php on line 15

So at least the tests need 8.6 core .
Or am I getting something wrong?

CommentFileSizeAuthor
#2 3018229-2.patch670 byteswim leers

Comments

gngn created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 3018229-2.patch670 bytes

So at least the tests need 8.6 core .

Correct. But it's only one test that needs this. All others work fine.

This patch might make PHPUnit ignore this test on 8.4 and 8.5.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Category: Bug report » Task
Issue tags: +BarcelonaMediaSprint
gngn’s picture

gngn commented

@Win Leers: Thanks - #2 worked for me.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Per #4.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Thanks, @gngn :)

  • Wim Leers committed bc91f29 on 8.x-1.x 
    Issue #3018229 by Wim Leers, gngn: Tests of current dev need 8.6 core (...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.