Capitalize the name of the module, because module names are proper nouns.
Also according to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | dark_mode-info-3016789-2.patch | 348 bytes | alonaoneill |
Comments
Comment #2
alonaoneill commentedI uploaded a patch that Capitalize the name of the module and dependency namespacing in the .info.yml file.
Thanks!
Comment #3
daggerhart commentedPatch applies cleanly. Tested on simplytest and now the module name appears in capital letters.
Comment #4
rajveergangwar@daggerhart and @alonaoneill
1st thanks alonaoneill for identifying the issue and thanks doggerhart for reviewing the patch.
Can you please tell how can i apply patch to uploaded module and assign credit to alonaoneill.
Comment #5
rajveergangwarIssue has been fixed to 8.x-3.x-dev and created new release 8.x-4.1
Comment #6
rajveergangwarIssue has been fixed on 8.x-3.x-dev and above release
Comment #7
rajveergangwar