Missing Kilometers and (for my case) Nautical Miles

CommentFileSizeAuthor
#5 3016669-5-expand-length-units.patch2.35 KBbojanz
#4 3016669-4.patch1.53 KBbojanz
#2 3016669-1-Missing-Kilometers-and-Nautical-Miles.patch1.33 KBviappidu

Comments

viappidu created an issue. See original summary.

viappidu’s picture

viappidu commented
StatusFileSize
new 3016669-1-Missing-Kilometers-and-Nautical-Miles.patch1.33 KB

Patch here

bojanz’s picture

bojanz commented
Status: Active » Needs work

Kilometer should come after the meter, not at the end of the list.
The symbol for kilometer should be "km", it's lowercase for the other SI length units as well.
$allowed_units should be broken into two lines, since it's now too long.

We need to expand LengthTest.

bojanz’s picture

bojanz commented
StatusFileSize
new 3016669-4.patch1.53 KB

Here's a quick improved patch.

Still needs the LengthTest changes.

bojanz’s picture

bojanz commented
Status: Needs work » Needs review
StatusFileSize
new 3016669-5-expand-length-units.patch2.35 KB

Here's a final patch.

bojanz’s picture

bojanz commented
Title: Kilometers and Nautical Miles » Add "kilometer" and "nautical mile" length units

  • bojanz committed 39ede4a on 8.x-1.x 
    Issue #3016669 by bojanz, viappidu: Add "kilometer" and "nautical mile"...
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.