fontawesome.module looks in wrong location for icons.json

Also, in both 2.x and 3.x, admin/config/media/icon/bundle/fontawesome shows only free icons, even though I have the Pro version.

I think I figured out what I'm doing wrong. Apparently, FA requires copying files to theme directories, and I hadn't replaced those with the new ones.

https://fontawesome.com/how-to-use/on-the-web/using-with/sass

I found the problem in fontawesome.module:

function fontawesome_get_metadata_filepath() {
  // Load the library so we can get the path.
  $library = libraries_load(FONTAWESOME_LIBRARY . '_svg');

  // Attempt to load the icons from the local library's metadata if possible.
  $metadataFile = drupal_realpath($library['library path'] . '/advanced-options/metadata/icons.json');
  // If we can't load the local file, use the included module icons file.
  if (!file_exists($metadataFile)) {
    $metadataFile = drupal_get_path('module', 'fontawesome') . '/metadata/icons.json';
  }
  return $metadataFile;
}

This module provides metadata/icons.json, but only the free icons. Since I am using the Pro version, my icons.json file is different.

The code above searches `'/advanced-options/metadata/icons.json'`, but the actual location in FA 5.5 is `'/metadata/icons.json'` (at least in the Pro version).

The result is that anyone using the module and library for the Pro version will not have any Pro-only icons showing.