Kinda cool if there'd be some CSV options to be able to manipulate over.
Like delimiter or enclosure.

Patch attached...

CommentFileSizeAuthor
#4 3016368-4.patch3.61 KBbojanz
#4 csv-import-screenshot.png141.71 KBbojanz
#2 added-a-csv-options-feature--3016368-2.patch3.25 KBeglaw

Comments

eglaw created an issue. See original summary.

eglaw’s picture

eglaw
Primary language English
Location Cittadella
commented
StatusFileSize
new added-a-csv-options-feature--3016368-2.patch3.25 KB

Patch attached

bojanz’s picture

bojanz commented
Status: Needs review » Needs work
Issue tags: -CSV import

Good idea.

Problems:
1) The patch doesn't patch phpcs due to trailing whitespace in newlines.
2) No docblocks were added for $csv_options in the various method signatures.
3) CSV options should be collapsed and shown after the mapping options
4) The options are always a single character, so the form elements need maxlength => 1

bojanz’s picture

bojanz commented
Status: Needs work » Needs review
StatusFileSize
new csv-import-screenshot.png141.71 KB
new 3016368-4.patch3.61 KB

Here's an updated patch addressing #3 feedback, and a screenshot. Tried playing with the fieldset titles a bit, though having both mapping and file options still feels a bit redundant.

  • bojanz committed cfff535 on 8.x-2.x authored by eglaw 
    Issue #3016368 by bojanz, eglaw: Add the CSV delimiter and enclosure...
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Let's proceed with this. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.