#3003121: Add an InlineForm API, stop using complex form elements has landed. We can use the new api to create an "entity" inline form that does the same thing that the IEF form element does.
This would allow us to stop using IEF in commerce_product completely, leaving commerce_order as the only remaining submodule that still needs IEF (at least until we replace the order items widget).

CommentFileSizeAuthor
#4 3016358-4.patch33.07 KBbojanz
#3 3016358-3.patch26.35 KBbojanz

Comments

bojanz created an issue. See original summary.

bojanz’s picture

bojanz commented
Title: Create an "entity" inline form to replace usage of the IEF form element » Create a "content_entity" inline form to replace usage of the IEF form element
Assigned: Unassigned » bojanz

Let's get this in for 2.12.

Retitling cause the inline form will be content entity specific.

bojanz’s picture

bojanz commented
Status: Active » Needs review
StatusFileSize
new 3016358-3.patch26.35 KB

Initial work.

TODO:
- Add logic that changes the inline entity language when the parent entity language is changed via dropdown.
- Expand ProductTranslationTest to test translating a product that always has a single variation
- Expand ProductTranslationTest to test that changing the product language (via dropdown) changes the variation language.

bojanz’s picture

bojanz commented
StatusFileSize
new 3016358-4.patch33.07 KB

Addressed the todos from #3. One last testrun.

  • bojanz committed 8c4024a on 8.x-2.x 
    Issue #3016358 by bojanz: Create a "content_entity" inline form to...
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Boom!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.