text_format_wrapper print `attributes` to the description what ends in uninterpretable aria attribute.text/drupal.text library) uses theme-provided classes for it's operations which may be broken in custom themes.Fix text_format_wrapper by printing attributes to the main wrapper and providing the missing attribute for the description.
Add js classes to the TextareaWithSummaryWidget for the text/drupal.text library (where text/drupal.text is attached).
Provide a patch with test.
Nothing.
None.
Nothing.
@Todo
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | text-textarea_inconsistencies-3016343-6.patch | 6.14 KB | huzooka |
Comments
Comment #2
huzookaComment #3
huzookaPatch without new test (to check what breaks).
Comment #4
huzookaComment #6
huzookaProvide the right test (without documenting the unavailable
requiredanddisabled).Hiding patch #3.
Comment #7
lauriiiThis change will break existing themes. We should find a way to make this so that this doesn't break on themes that extend Stable.
Comment #8
wim leersWe've long wanted to get rid of the "text with summary" field type. And hence also the widget. If we fix #1378350: Clean up the "Long text and summary" field, we won't need to fix this.
Comment #15
solideogloria commentedComment #16
dwwComing from #2421445-30: Text format wrapper does not honor description_display. To fix that bug, I wanted to entirely remove some code that lives in the wrong templates, yet it includes a @see comment pointing here. 😅 During self-review (#30.4) I pointed out the brokenness of
attributesnot being used in the wrapper element. Now that I'm reading the summary here, that's most of what this issue aims to fix. Hopefully this will be smaller and easier to land once we get thedescriptionout of the way entirely and leave that toform-element.html.twigitself (when{{ children }}is rendered).I won't formally mark this postponed, but it should probably wait until #2421445 lands...