Having members of a group with membership state set to "- None -" breaks certain functionality. I've included a screenshot of one such case when hitting the endpoint /group/%group/content (the Related entities tab "view" included with the group module).

I'm still trying to discern the reasoning and use cases for having such a membership state, but so far it seems to me that it implies the same thing as having no membership in a group, AND leads to undefined behavior, probably elsewhere on the site than the case mentioned above.
Technically, I'm noticing that a user of a group with a membership state of "- None -" has a record in the group_content_field_data table (of the group content type "membership" type) AND has no correlating (by entity_id foreign key relation) record in the group_content__group_membership_state table.
So, is this really the intended functionality?
At this point I believe it may be worth considering the purpose of this membership state and whether removing it (the "- None -" state) will make for a clearer user experience and eliminate undefined behavior that programmers will have to accommodate in development.
Steps to Reproduce:
- Create a Group Type
- Create a Group
- Add a User as a member of the Group
- Set the User's Membership State to "- None -" and Save
- Navigate to http://%yoursite/group/%group/content
| Comment | File | Size | Author |
|---|---|---|---|
| Screen Shot 2018-11-26 at 12.03.50 PM.png | 183.03 KB | percoction |
Comments
Comment #2
percoction commentedComment #3
gobinathmComment #4
percoction commentedAdded steps to reproduce to Issue summary
Comment #5
kristiaanvandeneyndeMembership states were a thing in the Drupal 7 version.