See the attachments for Code Sniffer suggestions both for:

  • Drupal 8 v2.3.1 (Latest - zip) Released October 21st, 2018
  • Drupal 8 v2.2 (Previous - zip) Released July 1st, 2018

as found on https://downloads.gigya.com/list.

CommentFileSizeAuthor
#2 code_sniffer_auto_fixes_v2_2-3016130-2.patch203.96 KBlolandese
#2 code_sniffer_auto_fixes_v2_3_1-3016130-2.patch204.64 KBlolandese
code_sniffer_suggestions-Drupal_8_v2_2.txt358.45 KBlolandese
code_sniffer_suggestions-Drupal_8_v2_3_1.txt359.62 KBlolandese

Comments

lolandese created an issue. See original summary.

lolandese’s picture

lolandese commented
StatusFileSize
new code_sniffer_auto_fixes_v2_3_1-3016130-2.patch204.64 KB
new code_sniffer_auto_fixes_v2_2-3016130-2.patch203.96 KB

Attached are two patches that apply the automated fixes:

For Drupal 8 v2.3.1 (Latest - zip) Released October 21st, 2018:

PHPCBF RESULT SUMMARY
------------------------------------------------------------------------------------------------------------------------
FILE                                                                                                    FIXED  REMAINING
------------------------------------------------------------------------------------------------------------------------
/Users/martin/Downloads/gigya 2/gigya/css/gigya.css                                                     2      0
/Users/martin/Downloads/gigya 2/gigya/gigya.api.php                                                     2      7
/Users/martin/Downloads/gigya 2/gigya/tests/src/Functional/GigyaTest.php                                563    21
/Users/martin/Downloads/gigya 2/gigya/gigya.install                                                     6      4
/Users/martin/Downloads/gigya 2/gigya/gigya.module                                                      8      3
/Users/martin/Downloads/gigya 2/gigya/src/Form/GigyaKeysForm.php                                        225    13
/Users/martin/Downloads/gigya 2/gigya/src/Helper/GigyaHelper.php                                        255    54
/Users/martin/Downloads/gigya 2/gigya/src/Helper/GigyaHelperInterface.php                               32     25
/Users/martin/Downloads/gigya 2/gigya_raas/gigya_raas.module                                            27     7
/Users/martin/Downloads/gigya 2/gigya_raas/tests/src/GigyaRaasTest.php                                  389    13
/Users/martin/Downloads/gigya 2/gigya_raas/gigya_raas.api.php                                           1      4
/Users/martin/Downloads/gigya 2/gigya_raas/gigya_raas.install                                           3      4
/Users/martin/Downloads/gigya 2/gigya_raas/src/GigyaController.php                                      611    11
/Users/martin/Downloads/gigya 2/gigya_raas/src/Form/GigyaSessionForm.php                                119    12
/Users/martin/Downloads/gigya 2/gigya_raas/src/Plugin/Block/GigyaRaasLinks.php                          17     1
/Users/martin/Downloads/gigya 2/gigya_raas/src/Plugin/Block/GigyaRaasLogin.php                          10     1
/Users/martin/Downloads/gigya 2/gigya_raas/src/Plugin/Block/GigyaRaasRegister.php                       10     1
/Users/martin/Downloads/gigya 2/gigya_raas/src/Plugin/Block/GigyaRaasProfile.php                        10     1
/Users/martin/Downloads/gigya 2/gigya_ds/gigya_ds.api.php                                               9      3
/Users/martin/Downloads/gigya 2/gigya_ds/tests/src/GigyaDsTests.php                                     82     3
/Users/martin/Downloads/gigya 2/gigya_ds/gigya_ds.module                                                34     14
/Users/martin/Downloads/gigya 2/gigya_user_deletion/gigya_user_deletion.api.php                         12     3
/Users/martin/Downloads/gigya 2/gigya_user_deletion/tests/src/Unit/GigyaUserDeletionUnitTest.php        262    17
/Users/martin/Downloads/gigya 2/gigya_user_deletion/tests/src/Functional/GigyaUserDeletionTest.php      122    6
/Users/martin/Downloads/gigya 2/gigya_user_deletion/gigya_user_deletion.module                          FAILED TO FIX
/Users/martin/Downloads/gigya 2/gigya_user_deletion/gigya_user_deletion.install                         53     0
/Users/martin/Downloads/gigya 2/gigya_user_deletion/src/Form/GigyaCronForm.php                          524    22
/Users/martin/Downloads/gigya 2/gigya_user_deletion/src/Helper/GigyaUserDeletionHelper.php              442    16
/Users/martin/Downloads/gigya 2/gigya_user_deletion/src/Helper/GigyaUserDeletionHelperInterface.php     33     6
------------------------------------------------------------------------------------------------------------------------
A TOTAL OF 4319 ERRORS WERE FIXED IN 29 FILES
------------------------------------------------------------------------------------------------------------------------
PHPCBF FAILED TO FIX 1 FILE
------------------------------------------------------------------------------------------------------------------------

For Drupal 8 v2.2 (Previous - zip) Released July 1st, 2018:

PHPCBF RESULT SUMMARY
----------------------------------------------------------------------------------------------------------------------
FILE                                                                                                  FIXED  REMAINING
----------------------------------------------------------------------------------------------------------------------
/Users/martin/Downloads/gigya/gigya/css/gigya.css                                                     2      0
/Users/martin/Downloads/gigya/gigya/gigya.api.php                                                     2      7
/Users/martin/Downloads/gigya/gigya/tests/src/Functional/GigyaTest.php                                563    21
/Users/martin/Downloads/gigya/gigya/gigya.install                                                     6      4
/Users/martin/Downloads/gigya/gigya/gigya.module                                                      8      3
/Users/martin/Downloads/gigya/gigya/src/Form/GigyaKeysForm.php                                        216    13
/Users/martin/Downloads/gigya/gigya/src/Helper/GigyaHelper.php                                        251    54
/Users/martin/Downloads/gigya/gigya/src/Helper/GigyaHelperInterface.php                               32     25
/Users/martin/Downloads/gigya/gigya_raas/gigya_raas.module                                            27     7
/Users/martin/Downloads/gigya/gigya_raas/tests/src/GigyaRaasTest.php                                  389    13
/Users/martin/Downloads/gigya/gigya_raas/gigya_raas.api.php                                           1      4
/Users/martin/Downloads/gigya/gigya_raas/gigya_raas.install                                           3      4
/Users/martin/Downloads/gigya/gigya_raas/src/GigyaController.php                                      608    11
/Users/martin/Downloads/gigya/gigya_raas/src/Form/GigyaSessionForm.php                                119    12
/Users/martin/Downloads/gigya/gigya_raas/src/Plugin/Block/GigyaRaasLinks.php                          17     1
/Users/martin/Downloads/gigya/gigya_raas/src/Plugin/Block/GigyaRaasLogin.php                          10     1
/Users/martin/Downloads/gigya/gigya_raas/src/Plugin/Block/GigyaRaasRegister.php                       10     1
/Users/martin/Downloads/gigya/gigya_raas/src/Plugin/Block/GigyaRaasProfile.php                        10     1
/Users/martin/Downloads/gigya/gigya_ds/gigya_ds.api.php                                               9      3
/Users/martin/Downloads/gigya/gigya_ds/tests/src/GigyaDsTests.php                                     82     3
/Users/martin/Downloads/gigya/gigya_ds/gigya_ds.module                                                34     14
/Users/martin/Downloads/gigya/gigya_user_deletion/gigya_user_deletion.api.php                         12     3
/Users/martin/Downloads/gigya/gigya_user_deletion/tests/src/Unit/GigyaUserDeletionUnitTest.php        262    17
/Users/martin/Downloads/gigya/gigya_user_deletion/tests/src/Functional/GigyaUserDeletionTest.php      122    6
/Users/martin/Downloads/gigya/gigya_user_deletion/gigya_user_deletion.module                          FAILED TO FIX
/Users/martin/Downloads/gigya/gigya_user_deletion/gigya_user_deletion.install                         53     0
/Users/martin/Downloads/gigya/gigya_user_deletion/src/Form/GigyaCronForm.php                          524    22
/Users/martin/Downloads/gigya/gigya_user_deletion/src/Helper/GigyaUserDeletionHelper.php              442    16
/Users/martin/Downloads/gigya/gigya_user_deletion/src/Helper/GigyaUserDeletionHelperInterface.php     33     6
----------------------------------------------------------------------------------------------------------------------
A TOTAL OF 4303 ERRORS WERE FIXED IN 29 FILES
----------------------------------------------------------------------------------------------------------------------
PHPCBF FAILED TO FIX 1 FILE
----------------------------------------------------------------------------------------------------------------------
lolandese’s picture

lolandese commented
Status: Active » Needs review