Comments

madhan.718@gmail.com’s picture

Title: Tablesorter Js not includes » Js and css files not included for sorting the tables
Issue summary: View changes
madhan.718@gmail.com’s picture

Issue summary: View changes
madhan.718@gmail.com’s picture

StatusFileSize
new49.06 KB
madhan.718@gmail.com’s picture

madhan.718@gmail.com’s picture

Title: Js and css files not included for sorting the tables » plugins not included for sorting the tables
Component: Miscellaneous » Code
Assigned: madhan.718@gmail.com » Unassigned
Status: Active » Closed (outdated)

Sorry, i am new for drupal. Without following the drupal standards i posted the issue wrongly. So i am closing the issue now and will create one new issue

madhan.718@gmail.com’s picture

Title: plugins not included for sorting the tables » Js and css files not included for sorting the tables
Issue summary: View changes
Status: Closed (outdated) » Needs review
madhan.718@gmail.com’s picture

StatusFileSize
new47.81 KB
jozzy_a’s picture

Thank you Madhan on your patch for making this module work in Drupal 8.

I have refactored how the libraries are retrieved, I have added instructions on how to use composer to automate the libraries download.
I have altered the libraries.yml and some of the JS.

malcomio’s picture

Seems like the patch from #9 also addresses #3015579: Configuration form doesn't save

malcomio’s picture

Status: Needs review » Reviewed & tested by the community
jozzy_a’s picture

The above patch was created with git --binary so we can create the .gif files using the patch. This functionality doesn't work on older versions of git, attached is the non binary patch where there is no gif files.

jozzy_a’s picture

aaron.ferris’s picture

This will override any settings added by another module when that modules page_attachment hook is run before the hook in this patch.

$settings = ['tablesorter' => ['zebra' => $zebra, 'odd' => $odd_class, 'even' => $even_class]];
$page['#attached']['drupalSettings'] = $settings;

I believe needs to be

$settings = ['zebra' => $zebra, 'odd' => $odd_class, 'even' => $even_class];
$page['#attached']['drupalSettings']['tablesorter'] = $settings;
aaron.ferris’s picture

Status: Reviewed & tested by the community » Needs work
aaron.ferris’s picture

aaron.ferris’s picture

Status: Needs work » Needs review
jozzy_a’s picture

@Damn-Deal-Done that is not how you ask for help if you are struggling to get a module working or applying the patch which has been provided by the "programmers" on this ticket.
Most module maintainers or people who supply patches are doing this voluntarily or part of a working project where you benefit at no cost to yourself. Please be respectful to those contributors and be constructive with your criticism.

monymirza’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

volkswagenchick’s picture

@Damn-Deal-Done - working in the issue queue can at times be frustrating, but as a community we strive to be welcoming to everyone. Using language like you did in comments #18 and #23 is unacceptable.
Drupal thrives on community collaboration.
I am unpublishing comments #18 and #23 as they are extremely unproductive.