Closed (fixed)
Project:
Tablesorter
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
22 Nov 2018 at 06:56 UTC
Updated:
4 Sep 2020 at 14:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
madhan.718@gmail.com commentedComment #3
madhan.718@gmail.com commentedComment #4
madhan.718@gmail.com commentedComment #5
madhan.718@gmail.com commentedComment #6
madhan.718@gmail.com commentedSorry, i am new for drupal. Without following the drupal standards i posted the issue wrongly. So i am closing the issue now and will create one new issue
Comment #7
madhan.718@gmail.com commentedComment #8
madhan.718@gmail.com commentedComment #9
jozzy_a commentedThank you Madhan on your patch for making this module work in Drupal 8.
I have refactored how the libraries are retrieved, I have added instructions on how to use composer to automate the libraries download.
I have altered the libraries.yml and some of the JS.
Comment #10
malcomio commentedSeems like the patch from #9 also addresses #3015579: Configuration form doesn't save
Comment #11
malcomio commentedComment #12
jozzy_a commentedThe above patch was created with git --binary so we can create the .gif files using the patch. This functionality doesn't work on older versions of git, attached is the non binary patch where there is no gif files.
Comment #13
jozzy_a commentedComment #14
aaron.ferris commentedThis will override any settings added by another module when that modules page_attachment hook is run before the hook in this patch.
I believe needs to be
Comment #15
aaron.ferris commentedComment #16
aaron.ferris commentedComment #17
aaron.ferris commentedComment #19
jozzy_a commented@Damn-Deal-Done that is not how you ask for help if you are struggling to get a module working or applying the patch which has been provided by the "programmers" on this ticket.
Most module maintainers or people who supply patches are doing this voluntarily or part of a working project where you benefit at no cost to yourself. Please be respectful to those contributors and be constructive with your criticism.
Comment #21
monymirzaComment #24
volkswagenchick@Damn-Deal-Done - working in the issue queue can at times be frustrating, but as a community we strive to be welcoming to everyone. Using language like you did in comments #18 and #23 is unacceptable.
Drupal thrives on community collaboration.
I am unpublishing comments #18 and #23 as they are extremely unproductive.