Problem/Motivation

 204 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead

Proposed resolution

inject the object use Drupal\Core\State\State;

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 xmlsitemap-drupal_injection_on_XmlSitemapEntitiesSettingsForm-3015350.patch2.05 KBthalles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs work » Needs review
FileSize
xmlsitemap-drupal_injection_on_XmlSitemapEntitiesSettingsForm-3015350.patch2.05 KB
alex_optim’s picture

alex_optim
Location 🇺🇦 Rivne
CreditAttribution: alex_optim at GOLEMS GABB, Drupal Ukraine Community for GOLEMS GABB, Drupal Ukraine Community commented

Good for me.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for Drupal Ukraine Community, GOLEMS GABB commented
Status: Needs review » Reviewed & tested by the community

Looks good, injection of state service is properly done.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor as a volunteer and at Drupal Ukraine Community, GOLEMS GABB for GOLEMS GABB, Drupal Ukraine Community commented

  • pifagor committed 967b598 on 8.x-1.x authored by thalles 
    Issue #3015350 by thalles, alex_optim, voleger, pifagor: Drupal...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor as a volunteer and at Drupal Ukraine Community, GOLEMS GABB for GOLEMS GABB, Drupal Ukraine Community commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.