API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21...

The 'uri_callback' property in the return is optional as can be seen from the implementation in tests: https://api.drupal.org/api/drupal/core%21modules%21system%21tests%21modu...

CommentFileSizeAuthor
#10 interdiff-9-10.txt895 bytesmsankhala
#10 uri_callback-optional-3014669-10.patch1.23 KBmsankhala
#9 3014669-8.patch1.23 KBgovind.maloo
#6 uri_callback_optional-3014669-5.patch1.34 KBkalyansamanta
#5 uri_callback_optional-3014669-5.patch887 byteskalyansamanta
#4 3014669-4.patch1.22 KBgovind.maloo
#2 3014669-2.patch895 byteshardikpandya

Comments

joachim created an issue. See original summary.

hardikpandya’s picture

hardikpandya commented
Status: Active » Needs review
StatusFileSize
new 3014669-2.patch895 bytes
joachim’s picture

joachim commented
Status: Needs review » Needs work

Thanks for the patch!

The paragraph for this item will need to be rewrapped, as the line you've changed now goes over the 80 char limit.

govind.maloo’s picture

govind.maloo commented
Status: Needs work » Needs review
StatusFileSize
new 3014669-4.patch1.22 KB
kalyansamanta’s picture

kalyansamanta commented
StatusFileSize
new uri_callback_optional-3014669-5.patch887 bytes

Please ignore this wrong file .

kalyansamanta’s picture

kalyansamanta commented
StatusFileSize
new uri_callback_optional-3014669-5.patch1.34 KB
awset’s picture

awset commented

hi, @govind.maloo,

I think the patch #4 needs indentation and should we put the "(optional)" after ":"?

so it should be uri_callback: (optional) The same as the 'uri_callback' key

Cheers
Awang

awset’s picture

awset commented
Status: Needs review » Needs work
govind.maloo’s picture

govind.maloo commented
Status: Needs work » Needs review
StatusFileSize
new 3014669-8.patch1.23 KB
msankhala’s picture

msankhala commented
StatusFileSize
new uri_callback-optional-3014669-10.patch1.23 KB
new interdiff-9-10.txt895 bytes

It should be uri_callback: (optional)instead of uri_callback (optional): to maintain the consistency across other optional keys.

joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

Looks good!

Thanks everyone!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 5a83be42e0 to 8.7.x and 0b2d0e37cb to 8.6.x. Thanks!

backported to 8.6.x since this is a docs fix.

  • alexpott committed 5a83be4 on 8.7.x 
    Issue #3014669 by kalyansamanta, govind.maloo, msankhala, hardikpandya,...

  • alexpott committed 0b2d0e3 on 8.6.x 
    Issue #3014669 by kalyansamanta, govind.maloo, msankhala, hardikpandya,...
govind.maloo’s picture

govind.maloo commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.