#2957381: Data model problems with Vocabulary hierarchy broke HEAD. Let's fix it.

CommentFileSizeAuthor
#3 3014289-3.patch1.04 KBgabesullice

Comments

gabesullice created an issue. See original summary.

gabesullice’s picture

gabesullice
Primary language English
commented
Related issues: +#2990908: [1.x] Drupal core compatibility release
gabesullice’s picture

gabesullice
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3014289-3.patch1.04 KB

Here it is.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Component: Documentation » Code
Category: Bug report » Task
Status: Needs review » Reviewed & tested by the community
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Passed on 8.6 and 8.7! 🚢

  • gabesullice committed 582a01b on 8.x-2.x 
    Issue #3014289 by gabesullice, Wim Leers: VocabularyTest is broken by...
amateescu’s picture

amateescu commented 
+++ b/tests/src/Functional/VocabularyTest.php
@@ -83,12 +83,15 @@ class VocabularyTest extends ResourceTestBase {
+    if (floatval(\Drupal::VERSION) < 8.7) {

Is there any reason not to use version_compare() here?

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

@amateescu We've used this pattern all over JSON:API. I'm fine with changing this across the board if you feel it's important :)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed
amateescu’s picture

amateescu commented

Nope, not at all, I was just curious because it looked strange :)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Hah :) Would you be interested in reviewing more of JSON:API? As soon as RC2 is tagged (one more issue to do!), we'll post an updated core patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.