_form.scss has CSS like this
.form-required:after {
background-image: url(../images/required.svg);
This only works if the SASS is compiled to a CSS file in a first level sub-directory of the theme, like my_theme/sub_dir/compiled.css
. In my case, the compiled CSS is in public://my_theme
(this is to allow multiple sites to share a single theme but with minor variations in SCSS variables based on settings such as colors).
True, for the moment there is only one occurrence so it's not too hard for me to handle it by adding this CSS override
.form-required:after {
background-image: url(/themes/my_theme/images/required.svg);
}
However my code can go out of date if the underlying theme code changes. The base bootstrap files avoid a similar problem by means of $icon-font-path
. Might we be able to do something similar here to be more robust for the future?
Comment | File | Size | Author |
---|---|---|---|
#5 | bootstrap.theme-root.3014107-interdiff-3-5.txt | 1.87 KB | AdamPS |
#5 | bootstrap.theme-root.3014107-5.patch | 2.42 KB | AdamPS |
#3 | bootstrap.theme-root.3014107-3.patch | 2.26 KB | AdamPS |
Comments
Comment #2
markhalliwellMakes sense, would be a good thing to have in cases like this.
Comment #3
AdamPS CreditAttribution: AdamPS at AlbanyWeb commentedHere is a patch, but beware that I am not very sure about the starter kits, and I don't use less.
Comment #4
markhalliwellThis is fine, but I think there should also be an
$image-path
variable as well.Comment #5
AdamPS CreditAttribution: AdamPS at AlbanyWeb commentedGood idea
Comment #6
markhalliwellComment #8
AdamPS CreditAttribution: AdamPS at AlbanyWeb commentedGreat thanks