This will allow to specify time in minutes. For example currently it is not possible to 30 minutes or 45 minutes or 1 hour 30 minutes.

CommentFileSizeAuthor
#5 3013604-5.patch2.81 KB_pratik_
#2 login_security-3013604-2-convert-track-time-to-minutes.patch2.75 KBknyshuk.vova

Issue fork login_security-3013604

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

knyshuk.vova created an issue. See original summary.

knyshuk.vova’s picture

knyshuk.vova commented
Status: Active » Needs review
StatusFileSize
new login_security-3013604-2-convert-track-time-to-minutes.patch2.75 KB
knyshuk.vova’s picture

knyshuk.vova commented
Related issues: +#3015306: Allow using minutes in track time ( D7 )
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 8.x-1.x-dev » 2.x-dev
Status: Needs review » Needs work
Issue tags: +Needs reroll

@knyshuk.vova could you reroll this against 2.x?

_pratik_’s picture

_pratik_
Primary language English
Location Indore
commented
StatusFileSize
new 3013604-5.patch2.81 KB

Rerollled for 2.x-dev

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@_pratik_: Thanks could you please do that as Merge Request (MR)? That would be easier to review and commit. Thanks!

sourabhjain made their first commit to this issue’s fork.

sourabhjain opened merge request !9

sourabhjain’s picture

sourabhjain
Primary language English
commented
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue tags: -Needs reroll

Thanks, LGTM!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

We'll proceed here with review, once someone created a MR from the patch.

sourabhjain’s picture

sourabhjain
Primary language English
commented

@anybody now the MR looks mergeable so you can start with the review.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil

LGTM, thanks @sourabhjain!

@Grevil could you do the final review please? I think this is fine.

Grevil made their first commit to this issue’s fork.

grevil’s picture

grevil commented
Status: Needs review » Reviewed & tested by the community

The Update hook works as expected and the Form additions look good to me!

Thank you all!

grevil’s picture

grevil commented
grevil’s picture

grevil commented

grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.