Problem/Motivation

Drupal and DrupalPractice asked dependency injection on ManageResolverRelationships

Proposed resolution

inject Drupal\Core\Form\FormBuilder and Drupal\Core\DependencyInjection\Container;

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#12 ctools-dependency_injection_on_ManageResolverRelationships-3013307-11.patch2.88 KBandrtroe
#9 ctools-dependency_injection_on_ManageResolverRelationships-3013307-9.patch2.89 KBandrtroe
#8 ctools-dependency_injection_on_ManageResolverRelationships-3013307-8-D8.patch2.85 KBthalles
#3 ctools-dependency_injection_on_ManageResolverRelationships-3013307.patch2.58 KBthalles

Comments

Thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs review » Needs work
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new ctools-dependency_injection_on_ManageResolverRelationships-3013307.patch2.58 KB

Follow the ptach!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Title: Drupal dependency injection on RequiredContext » Drupal dependency injection on ManageResolverRelationships
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Assigned: thalles » Unassigned
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented 
+++ b/src/Form/ManageResolverRelationships.php
@@ -24,6 +26,40 @@ abstract class ManageResolverRelationships extends FormBase {
+      $container->get('service_container'),

Why not just use the $container we are working with?

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new ctools-dependency_injection_on_ManageResolverRelationships-3013307-8-D8.patch2.85 KB

Follow the new patch!

andrtroe’s picture

andrtroe commented
StatusFileSize
new ctools-dependency_injection_on_ManageResolverRelationships-3013307-9.patch2.89 KB

You had a small typo in comments, I have fixed it.

andrtroe’s picture

andrtroe commented
Status: Needs review » Reviewed & tested by the community
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Thanks for the corrections @Andrey!

andrtroe’s picture

andrtroe commented
StatusFileSize
new ctools-dependency_injection_on_ManageResolverRelationships-3013307-11.patch2.88 KB

Sorry, missed one wrong comment.

  • joelpittet committed 2bf5161 on 8.x-3.x authored by thalles 
    Issue #3013307 by thalles, andrey.troeglazov, joelpittet: Drupal...
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

Thank you two. I tweaked (lowercase without the word 'service') the variable docblocs and removed the create method inline comments on commit and pushed to the dev branch.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

Thanks!
#ehTois!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.