LogicException Form errors cannot be set after form validation has finished

The massageFormValues is triggered twice, first during validation in validateForm and if there were no errors during doSubmitForm.

It seems your validation provides inconsistent results, thus i would expect that you have some code in place that modifies data on validation?

Tested this without IEF and the validation checks consistent values.

From the description above i can't seem to understand what the relation to IEF is nor what speciflc violation error was triggered.
So can't help much here.

Patch works well for us.

I'm using Drupal 8.7.0-alpha1 and the error below is still there after applying #5

LogicException: Form errors cannot be set after form validation has finished. in Drupal\Core\Form\FormState->setErrorByName() (line 1057 of /Users/denniscohn/Sites/flean/web/core/lib/Drupal/Core/Form/FormState.php).

I'm using Drupal 8.7.0-beta2 and tried applying this patch to Paragraphs 1.8 and 1.x-dev and in both cases I continued seeing the same error,

LogicException: Form errors cannot be set after form validation has finished. in Drupal\Core\Form\FormState->setErrorByName() (line 1057 of /app/web/core/lib/Drupal/Core/Form/FormState.php).

It's obviously a very simple and concise patch....any other thoughts what might be going on here?

Also please help to extend our tests to cover this use case.

Having same issue since 8.7.0.

I have paragraph type "image_single" which has entity reference field "field_media_image" . I use "Media Library" widget and this error happens when I click "Added media". For paragraph field I use EXPERIMENTAL widget. There is not nested paragraphs, to be sure. Since it looks like this issue #3003150: Media library causes validation errors when it is used in a required field of a nested form, but patch from that issue is not helps with this problem and patch from #3013171-5: LogicException Form errors cannot be set after form validation has finished also not fix the problem.

UPD With "Paragraphs Classic" field widget media select dialog is opens, but when select value, it "saves" without any values and errors.

My error trace is

LogicException: Form errors cannot be set after form validation has finished. in Drupal\Core\Form\FormState->setErrorByName() (line 1057 of core/lib/Drupal/Core/Form/FormState.php). Drupal\Core\Form\FormState->setError(Array, Object) (Line: 466)
Drupal\Core\Field\WidgetBase->flagErrors(Object, Object, Array, Object) (Line: 264)
Drupal\Core\Entity\Entity\EntityFormDisplay->flagWidgetsErrorsFromViolations(Object, Array, Object) (Line: 251)
Drupal\Core\Entity\Entity\EntityFormDisplay->validateFormValues(Object, Array, Object) (Line: 2231)
Drupal\paragraphs\Plugin\Field\FieldWidget\ParagraphsWidget->massageFormValues(Array, Array, Object) (Line: 381)
Drupal\Core\Field\WidgetBase->extractFormValues(Object, Array, Object) (Line: 2284)
Drupal\paragraphs\Plugin\Field\FieldWidget\ParagraphsWidget->extractFormValues(Object, Array, Object) (Line: 231)
Drupal\Core\Entity\Entity\EntityFormDisplay->extractFormValues(Object, Array, Object) (Line: 338)
Drupal\Core\Entity\ContentEntityForm->copyFormValuesToEntity(Object, Array, Object) (Line: 304)
Drupal\Core\Entity\EntityForm->buildEntity(Array, Object) (Line: 159)
Drupal\Core\Entity\ContentEntityForm->buildEntity(Array, Object) (Line: 289)
Drupal\Core\Entity\EntityForm->submitForm(Array, Object) (Line: 149)
Drupal\Core\Entity\ContentEntityForm->submitForm(Array, Object)
call_user_func_array(Array, Array) (Line: 111)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 51)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 590)
Drupal\Core\Form\FormBuilder->processForm('node_blog_entry_edit_form', Array, Object) (Line: 319)
Drupal\Core\Form\FormBuilder->buildForm('node_blog_entry_edit_form', Object) (Line: 93)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 582)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 693)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

I was also getting this issue with Drupal 8.7 and paragraphs 1.8. My LogicException triggered in the if statement above:

if ($widget_state['paragraphs'][$item['_original_delta']]['mode'] === 'edit') {
  $display->validateFormValues($paragraphs_entity, $element[$item['_original_delta']]['subform'], $form_state);
}

Changing this to:

if (!$form_state->isValidationComplete() && $widget_state['paragraphs'][$item['_original_delta']]['mode'] === 'edit') {
  $display->validateFormValues($paragraphs_entity, $element[$item['_original_delta']]['subform'], $form_state);
}

In combo with the patch in #5 resolved it for me.
I have attached my patch.

Patch #13 is solved my problem, where #5 can't.

I can confirm that the patch #13 fixed the bug of media library not opening when using Paragraphs with referenced media field and experimental widget.

Oh and since there is a patch, updating the issue status.

A quick hint: While we have seen multiple runs of validations eating time (and like here resulting in errors), we also have seen cases where nested structures skip validation completely because somehow it was partially skipped but on some level marked as validated (maybe also collapsing related). Some operations (for instance the new convert patch) can produce temporary illegal situations within the UI. We need to make sure that items are guaranteed to be validated before saving.

We definitively need to check the quality of our validation tests combined with nesting, collapsing and maybe more of the complex operations.

Turns out that the patch from #13 somehow brakes JSON:API responses when using included paragraphs fields in the jsonapi request. Didn't have time to debug why.

So it did fix the media library not working, but caused a regression for jsonapi.
Unrelated bug with config.

And it seems that miro_dietiker also hints that there's more work to be done with this issue.

#13 worked for me too.

The root problem here is that the method is called at least twice and after the first execution the form is already validated. Suppressing the validation doesn't seem to be a good fix (but as a quick fix it works perfectly fine).

+1. Confirmed, #13 worked for me on Drupal 8.7.1 and PHP 7.3. Thanks!

RTBC +1. The patch in #13 worked for me as well. Patch applied cleanly and solved my issue. Using core 8.7.5 and module 8.x-1.8. Thanks!

I tested #13 with a large number of paragraphs (Paragraphs Performance module in combination with latest Drupal core, latest development branch of Paragraphs and ERR modules) where I get on average ~20% (~0.5s difference) faster save times with the patch compared to results without the patch.

I think the issues in #17 aren't really related to this MR and aren't blocking it.

The bugs are non-trivial to test for, and at least the one in media_library is also being fixed in core, so wouldn't help us much then to test I think.

This does have considerable performance improvements, passes our existing tests, we also tested it with our distribution extensively and there were also several reports from others that it is fixing their problems. RTBC.

Yay then, committed. :-) and attributed all, thx!