Problem/Motivation

Drupal and DrupalPractice asked dependency injection on src/Form/ManageContext.php

Proposed resolution

inject Drupal\Core\DependencyInjection\Container

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 ctools-drupal_dependency_injection_on_ManageContext-3013153-6.patch2.52 KBandrey.troeglazov
#5 ctools-drupal_dependency_injection_on_ManageContext-3013153-5-D8.patch2.52 KBthalles
#2 ctools-drupal_dependency_injection_on_ManageContext-3013153.patch2.29 KBthalles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs work » Needs review
FileSize
ctools-drupal_dependency_injection_on_ManageContext-3013153.patch2.29 KB

Hi, Congratulations for the module!
follow my little contribution

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Assigned: thalles » Unassigned
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented 
+++ b/src/Form/ManageContext.php
@@ -53,7 +61,11 @@ abstract class ManageContext extends FormBase {
+      $container->get('service_container')

Is there a reason it's not just passing the $container itself?

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
FileSize
ctools-drupal_dependency_injection_on_ManageContext-3013153-5-D8.patch2.52 KB

Following is a more appropriate patch!

andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented
FileSize
ctools-drupal_dependency_injection_on_ManageContext-3013153-6.patch2.52 KB

Fixed one wrong comment.

andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented
Status: Needs review » Reviewed & tested by the community

  • joelpittet committed b4a48f7 on 8.x-3.x authored by thalles 
    Issue #3013153 by thalles, andrey.troeglazov, joelpittet: Drupal...
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Status: Reviewed & tested by the community » Fixed

Minor changes fixed on commit. Thanks I've pushed this to the dev branch.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.