Problem/Motivation

On translations update page: /admin/reports/translations

There is fieldset, collapsed by default, that uses LTR version of collapse icon and is not located properly for RTL.

See screenshot below:

Collapse icon on translations update page needs RTL version

Steps to reproduce

Go to /admin/reports/translations for a RTL language

Proposed resolution

Remaining tasks

Update the patch
Manual testing, link screenshots in the IS
Review
Commit

User interface changes

Before

After

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#17 Screenshot 2023-05-08 at 8.08.26 PM.png87.43 KBsmustgrave
#16 3013069-16.patch2.21 KBgauravvvv
#15 Screenshot 2023-02-04 at 21-02-42 تحديثات الترجمة المتوفرة dev2-web.png28.6 KBquietone
#2 core-locale-collapse-icon-rtl-support-issue-3013069.patch2.12 KBisraelshmueli
collapse-icon-on-translations-update-needs-RTL.png26.59 KBisraelshmueli

Comments

israelshmueli created an issue. See original summary.

israelshmueli’s picture

israelshmueli commented
StatusFileSize
new core-locale-collapse-icon-rtl-support-issue-3013069.patch2.12 KB

The enclosed patch should fix that on stable theme CSS an on core's locale module CSS

israelshmueli’s picture

israelshmueli commented
israelshmueli’s picture

israelshmueli commented
Status: Active » Needs review

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs review » Postponed (maintainer needs more info)

Last comment was 4 years ago. Can someone confirm if this is still an issue in D10 please

quietone’s picture

quietone commented
Component: Stable theme » Stable 9 theme

Moving remaining issues for 'Stable theme' to 'Stable 9 theme' based on #3332485-5: [Meta] Stable issue triage by markconroy.

quietone’s picture

quietone commented
Issue summary: View changes
Status: Postponed (maintainer needs more info) » Needs work
Issue tags: +Bug Smash Initiative
StatusFileSize
new Screenshot 2023-02-04 at 21-02-42 تحديثات الترجمة المتوفرة dev2-web.png28.6 KB

I tested this on Drupal 10.1.x, umami install. I added Arabic and modified \Drupal\locale\Form\TranslationStatusForm::prepareUpdateData to force all languages to need updates. Navigating to ar/admin/reports/translations and the problem was reproducible.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
StatusFileSize
new 3013069-16.patch2.21 KB

I have attached the patch for fixed the issue in RTL. please review

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative
StatusFileSize
new Screenshot 2023-05-08 at 8.08.26 PM.png87.43 KB

fixed

Confirmed this is now fixed.

  • bnjmnm committed bb1f6574 on 11.x 
    Issue #3013069 by israelshmueli, Gauravvvv, smustgrave: Locale module is...

  • bnjmnm committed fc8bf4a7 on 10.1.x 
    Issue #3013069 by israelshmueli, Gauravvvv, smustgrave: Locale module is...
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Component: Stable 9 theme » CSS
Status: Reviewed & tested by the community » Fixed

Great work getting things verified, fixed and reviewed in a concise and effective manner.

Committed to 11.0.x, cherry picked to 10.1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.