Suppose you add a views block in a home box page, and you later delete the views block.
Homebox still tries to load the deleted block. Hence a plugin not found exception is thrown.

CommentFileSizeAuthor
#3 homebox_catch_exception-3012844-12850838.patch937 bytesbonrita

Comments

bonrita created an issue. See original summary.

bonrita’s picture

bonrita commented

Catch the exception.

bonrita’s picture

bonrita commented
StatusFileSize
new homebox_catch_exception-3012844-12850838.patch937 bytes

Catch exception.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Active » Needs work

Looks okay, could use a code comment explaining the exception handling.

bonrita’s picture

bonrita commented

Hi @drumm,

Please can you give an example of what you mean by the above comment and l will fix it as requested. Thanks in advance for reviewing and advise.

bonrita’s picture

bonrita commented
Assigned: bonrita » Unassigned
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 8.x-1.x-dev » 2.0.x-dev

Please re-check with latest 2.0.x-dev!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue tags: -Uncaught exception

Suggesting to show a message and log an error via logger to tell the user which block to remove.

If not removable for the user, it should be auto-deleted and logged. But that's quite dangerous... ;) Better let the user decide, if possible.

grevil’s picture

grevil commented
Status: Needs work » Fixed

Fixed in #3264557: Plan for 2.0.0-alpha1 bugfix release

Thank you @bonrita for the patch! I added a logger notice, messenger error and edited the rendered block, when this Exception gets thrown.

  • Grevil committed 36cfe00 on 2.0.x authored by bonrita 
    Issue #3012844 by bonrita, Grevil: Exception when pre-added view block...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.