Closed (fixed)
Project:
Feeds
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
8 Nov 2018 at 14:46 UTC
Updated:
20 Feb 2019 at 10:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
t-loPatched
Comment #3
t-loComment #5
t-loCorrected capitalisation and re-alphabetised use statements
Comment #6
megachriz@T-lo
Thanks for working on this. It appears that it needs more work than just changing the use statements though. Without having looked at where in the code this private temp store is used, I say that it's likely that a different service needs to be passed around.
Comment #7
idebr commentedFixed the dependency injection in \Drupal\feeds\Plugin\Action\DeleteFeed
Comment #8
megachrizI get an error when trying to delete a feed when using the action "Delete selected feeds" on admin/content/feed.
This is because DeleteMultiple::create() still passes the service 'user.private_tempstore'. It would be cool if we had test coverage for this action.
Comment #9
megachrizOpened #3030879: Add test coverage for "feeds_feed_delete_action" for adding test coverage for the action "Delete selected feeds".
Comment #10
megachrizAlright, test coverage has now catched the bug introduced by the patch in #7.
New patch to fix that bug.
Comment #12
megachrizCorrecting namespaces.
Comment #14
megachrizCommitted #12.