Problem/Motivation

Drupal and DrupalPractice ask for changes in src/Tests/GoogleAnalyticsBasicTest.php

Proposed resolution

Apply changes askeds in src/Tests/GoogleAnalyticsBasicTest.php

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 google_analitycs-coding_standards_in_GoogleAnalyticsBasicTest-3011986-2.patch1.96 KBthalles
#2 google_analitycs-coding_standards_in_GoogleAnalyticsBasicTest-3011986.patch1.96 KBthalles

Comments

Thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new google_analitycs-coding_standards_in_GoogleAnalyticsBasicTest-3011986.patch1.96 KB

Hi, follow the patch!

Status: Needs review » Needs work

The last submitted patch, 2: google_analitycs-coding_standards_in_GoogleAnalyticsBasicTest-3011986.patch, failed testing. View results

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new google_analitycs-coding_standards_in_GoogleAnalyticsBasicTest-3011986-2.patch1.96 KB

Status: Needs review » Needs work

The last submitted patch, 4: google_analitycs-coding_standards_in_GoogleAnalyticsBasicTest-3011986-2.patch, failed testing. View results

  • hass committed 563e373 on 8.x-3.x authored by thalles 
    Issue #3011986 by thalles: Coding standards in GoogleAnalyticsBasicTest
hass’s picture

hass commented
Version: 8.x-2.x-dev » 8.x-3.x-dev
Status: Needs work » Fixed

Fixed the bug

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.