Problem/Motivation

Drupal and DrupalPractice ask for changes in file google_analytics/google_analytics.module

Proposed resolution

Apply changes askeds in google_analytics/google_analytics.module

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#15 google_analitycs-standards_in_google_analitycs.module-3011973-5.patch2.89 KBthalles
#13 google_analitycs-standards_in_google_analitycs.module-3011973-4.patch822 bytesthalles
#8 google_analitycs-standards_in_google_analitycs.module-3011973.png207.09 KBthalles
#6 google_analitycs-standards_in_google_analitycs.module-3011973-3.patch1.91 KBthalles
#4 google_analitycs-standards_in_google_analitycs.module-3011973-2.patch1.93 KBthalles
#2 google_analitycs-standards_in_google_analitycs.module-3011973.patch0 bytesthalles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs work » Needs review
FileSize
google_analitycs-standards_in_google_analitycs.module-3011973.patch0 bytes

Hi, follow the patch

Status: Needs review » Needs work

The last submitted patch, 2: google_analitycs-standards_in_google_analitycs.module-3011973.patch, failed testing. View results

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs work » Needs review
FileSize
google_analitycs-standards_in_google_analitycs.module-3011973-2.patch1.93 KB

Hi, follow the patch

hass’s picture

hass CreditAttribution: hass commented
Status: Needs review » Needs work 
+++ b/google_analytics.module
@@ -7,6 +7,7 @@
+ * @codingStandardsIgnoreLine

@@ -125,7 +127,7 @@ function google_analytics_page_attachments(array &$page) {
+        /* $page['#attached']['library'][] = 'google_analytics/google_analytics.test'; */

Incorrect change.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs work » Needs review
FileSize
google_analitycs-standards_in_google_analitycs.module-3011973-3.patch1.91 KB
hass’s picture

hass CreditAttribution: hass commented 
+++ b/google_analytics.module
@@ -25,6 +25,7 @@ use Drupal\google_analytics\Component\Render\GoogleAnalyticsJavaScriptSnippet;
+// @codingStandardsIgnoreLine
 define('GOOGLE_ANALYTICS_TRACKFILES_EXTENSIONS', '7z|aac|arc|arj|asf|asx|avi|bin|csv|doc(x|m)?|dot(x|m)?|exe|flv|gif|gz|gzip|hqx|jar|jpe?g|js|mp(2|3|4|e?g)|mov(ie)?|msi|msp|pdf|phps|png|ppt(x|m)?|pot(x|m)?|pps(x|m)?|ppam|sld(x|m)?|thmx|qtm?|ra(m|r)?|sea|sit|tar|tgz|torrent|txt|wav|wma|wmv|wpd|xls(x|m|b)?|xlt(x|m)|xlam|xml|z|zip');

What is wrong with this constant?

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Issue summary: View changes
FileSize
google_analitycs-standards_in_google_analitycs.module-3011973.png207.09 KB

@hass the drupal ask for use on Class or interface, look:

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented

[phpcs] Global constants should not be used, move it to a class or interface

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented

@hass, I put @ignore... because I too think some things of standards of drupal unnecessaries.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Assigned: thalles » Unassigned
hass’s picture

hass CreditAttribution: hass commented
Issue summary: View changes

the drupal ask for use on Class or interface, look:

Than we should change it this way I guess and not just an ignore.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
FileSize
google_analitycs-standards_in_google_analitycs.module-3011973-4.patch822 bytes

Follow the patch.

Status: Needs review » Needs work

The last submitted patch, 13: google_analitycs-standards_in_google_analitycs.module-3011973-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
FileSize
google_analitycs-standards_in_google_analitycs.module-3011973-5.patch2.89 KB

Follow the patch.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs work » Needs review
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented

Hi @hass, what's up?
Would that be the way you wanted it?

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented

Hi @hass, is there anything missing yet?
I await a return to proceed.

hass’s picture

hass CreditAttribution: hass commented

Looks ok

  • hass committed d0eb0b3 on 8.x-3.x authored by thalles 
    Issue #3011973 by thalles: Coding standards in google_analytics.module

  • hass committed f573683 on 8.x-2.x authored by thalles 
    Issue #3011973 by thalles: Coding standards in google_analytics.module
hass’s picture

hass CreditAttribution: hass commented
Status: Needs review » Fixed

Ported to Matomo

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.