There is no check for the empty value of $external_settings['external_location'] before it is used in drupal_add_js(). This results in rendering of the script tag with empty src: <script type="text/javascript" src=""></script>.

Patch is coming.

CommentFileSizeAuthor
#8 external_scripts_are_rendered_empty-3011882-4.patch2.3 KBdaniel.moberly
#6 external_scripts_are_rendered_empty-3011882-3.patch2.19 KBdaniel.moberly
#2 external_scripts_are_rendered_empty-3011882-2.patch1.98 KBalex.skrypnyk

Comments

alex.designworks created an issue. See original summary.

alex.skrypnyk’s picture

alex.skrypnyk
he/him
Primary language English
Location Melbourne
commented
StatusFileSize
new external_scripts_are_rendered_empty-3011882-2.patch1.98 KB

Attaching a patch

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: external_scripts_are_rendered_empty-3011882-2.patch, failed testing. View results

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
commented
Status: Needs work » Needs review

Just ignore the test

daniel.moberly’s picture

daniel.moberly commented
StatusFileSize
new external_scripts_are_rendered_empty-3011882-3.patch2.19 KB

Thanks for the patch alex - I think its better if we test for empty outside of the if/else so we only have to check once - I also added a warning message to help out.

See revised patch.

Status: Needs review » Needs work

The last submitted patch, 6: external_scripts_are_rendered_empty-3011882-3.patch, failed testing. View results

daniel.moberly’s picture

daniel.moberly commented
StatusFileSize
new external_scripts_are_rendered_empty-3011882-4.patch2.3 KB

Revising patch to pass testing

daniel.moberly’s picture

daniel.moberly commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 8: external_scripts_are_rendered_empty-3011882-4.patch, failed testing. View results

daniel.moberly’s picture

daniel.moberly commented
Status: Needs work » Needs review
truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
commented
Status: Needs review » Reviewed & tested by the community

  • Daniel.Moberly committed c0c081e on 7.x-3.x 
    Issue #3011882 by Daniel.Moberly, alex.designworks: External scripts and...
daniel.moberly’s picture

daniel.moberly commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.