Problem/Motivation

Currently the js/color_field_widget_box.js file generates buttons for admin forms. This works great! However, none of these buttons have unique values or ids, and as a result trying to do any automated testing with Behat on an admin form with a required color field is impossible.

Proposed resolution

Update the js/color_field_widget_box.js to also include a value on the box/button so it can be uniquely identified by Behat and other automation frameworks.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#2 color-box-button-values-3011853-2.patch507 bytesmikemadison
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikemadison created an issue. See original summary.

mikemadison’s picture

mikemadison CreditAttribution: mikemadison at Acquia commented
FileSize
color-box-button-values-3011853-2.patch507 bytes
mikemadison’s picture

mikemadison CreditAttribution: mikemadison at Acquia commented
Status: Active » Needs review
NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde as a volunteer and commented
Assigned: mikemadison » Unassigned
Status: Needs review » Fixed

Oops missed that this was actually ready, best to unassign ;) (Although was getting behind on tickets anyways so not like it delayed it much)

I've mostly used jquery [] selectors to get around that but if it helps, it probably is better to set the value.
Thanks for the patch, applied.

  • mikemadison authored 8132c5f on 8.x-2.x 
    Issue #3011853 by mikemadison: Color Box Button Values

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.