All dependencies must be prefixed by project name, So please apply new {project}:{module} format for dependencies in info.yml file

It is supported since 8.0 and 7.40 Change Record: Project namespaces can now be added for module dependencies, and is now a Best Practice Define project dependencies in core module .info files).

It is useful for DrupalCi to download the right dependencies and Installation profiles to work well. So sooner is better.
Hope this helps.

CommentFileSizeAuthor
#6 Screen Shot 2019-03-01 at 6.14.30 AM.png27.04 KBvolkswagenchick
#5 Update_dependencies_format_in_info.yml_3011673-5.patch866 byteschipway
#3 dependency_Social simple.png31.64 KBAanal.addweb
#2 Update_dependencies_format_in_info.yml_3011673-2.patch504 byteschipway

Comments

chipway created an issue. See original summary.

chipway’s picture

chipway commented
Assigned: chipway » Unassigned
Status: Needs work » Needs review
StatusFileSize
new Update_dependencies_format_in_info.yml_3011673-2.patch504 bytes

Here is the patch. Please review.

Aanal.addweb’s picture

Aanal.addweb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new dependency_Social simple.png31.64 KB

@chipway, Thanks for providing the patch. Your patch is working fine for me. As per the mentioned changes, I matched it with Pareview. PFA.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Reviewed & tested by the community » Needs work

According to drupal coding standards, the name of the module should be in title case. Maybe this would be a good fix in this patch?? Marking needs work.

https://www.drupal.org/docs/develop/documenting-your-project/help-text-s...

Thanks!

chipway’s picture

chipway commented
Title: All dependencies must be prefixed » All dependencies must be prefixed + capitalize name
Status: Needs work » Needs review
StatusFileSize
new Update_dependencies_format_in_info.yml_3011673-5.patch866 bytes

Good idea AmyJune,

Here is a reroll with capitalization.

Please review.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2019-03-01 at 6.14.30 AM.png27.04 KB

New patch looks good. Applies locally and on simplytest.me. Namespacing is aligned to Documentation STandards and the project is now in title case on the Extend page. Screenshot attached.

Marking RTBC, thanks for the re-roll.

  • chipway authored 8659195 on 8.x-1.x 
    Issue #3011673 by chipway, volkswagenchick, Aanal.addweb: All...
flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.