All dependencies must be prefixed by project name, So please apply new {project}:{module} format for dependencies in info.yml file

It is supported since 8.0 and 7.40 Change Record: Project namespaces can now be added for module dependencies, and is now a Best Practice Define project dependencies in core module .info files).

And I suggest to add a dependency on main module as it relies on Views.
It is useful for DrupalCi to download the right dependencies and Installation profiles to work well. So sooner is better.
Hope this helps.

Comments

chipway created an issue. See original summary.

chipway’s picture

Here is the patch. Please review.
I also normalized the existing dependency on Views.

chipway’s picture

Assigned: chipway » Unassigned
Status: Needs work » Needs review
Aanal.addweb’s picture

Assigned: Unassigned » Aanal.addweb
Aanal.addweb’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new30.01 KB

@chipway, Thanks for the patch, it is working fine as per the above-mentioned requirements with #2. I refer pareview also, to verify your implemented changes. PFA

  • jludwig committed e00e629 on 8.x-1.x authored by chipway
    Issue #3011442 by chipway, Aanal.addweb: Must add prefix to dependencies
    
jludwig’s picture

Assigned: Aanal.addweb » Unassigned
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.