webform.export.inc uses deprecated PHP4 constructors

Webform 3 receives critical bug fixes only. If the WF3 community gets this to RTBC, I will commit it.

The patch applies, fixes the "deprecated" messages and doesn't break any other stuff.

I note there is a nearly identical solution posted in a related issue (https://www.drupal.org/project/webform/issues/2938667#comment-12988014) - which is what makes me RTBC this.

Is hiding a bunch of error messages "critical" enough? If not, I am okay with closing this issue instead.

Rethinking this. It is all fine for Webform to update its own constructors, but what about making them backwards-compatible for contrib and custom modules that might have extended these export handlers?

We could create constructors that just call the old constructors as regular old public methods. It's not pretty, but it suppresses the warnings and supports legacy code.

  public function __construct($options) {
    $this->webform_exporter_excel($options);
  }

That sounds reasonable to me.

Here's a patch to match the latest security release.

I took the patch from #4 but implemented as noted in #8.

Thanks for the patch. I think it would be better if they were the other way around, that is, the __construct() methods contain the actual function and the old function names are wrappers with @deprecated comments.

I think this is what you're looking for @Liam Morland.

Yes, that is the idea. We just need someone else to review and test.

We are now using this at Lehigh University and it is in place for ~120 sites without issues.

Thanks everyone.