Problem/Motivation

the elseif is not within the Drupal and DrupalPractice standards

Proposed resolution

Apply the standards

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 2018-11-08 11_47_11-MINGW64__c_xampp_htdocs_drupal_modules_pathauto.png4.49 KBAkshay kashyap
#3 pathauto-else_if_is_not_in_Drupal_standards-3010804.patch1.02 KBthalles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs work » Needs review

Hi, congrats for the module!
Follow the patch.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
FileSize
pathauto-else_if_is_not_in_Drupal_standards-3010804.patch1.02 KB

Sorry!
Now yes!

Akshay kashyap’s picture

Akshay kashyap CreditAttribution: Akshay kashyap as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
FileSize
2018-11-08 11_47_11-MINGW64__c_xampp_htdocs_drupal_modules_pathauto.png4.49 KB

@Thalles Thanks for the patch. i have applied your patch its working fine for me, i have attached the screenshot for the reference.

Akshay kashyap’s picture

Akshay kashyap CreditAttribution: Akshay kashyap as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Needs review » Reviewed & tested by the community
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented

Thank's!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented

Hi @Akshay kashyap, Can you test the issue https://www.drupal.org/project/pathauto/issues/3011482 too?

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Assigned: thalles » Unassigned
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Committed.

  • Berdir committed 790abf0 on 8.x-1.x authored by thalles 
    Issue #3010804 by thalles, Akshay kashyap: else if is not in Drupal...
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.