Problem/Motivation

The Drupal and DrupalPractice request depency injection

Proposed resolution

Inject objects of type ConfigFactoryInterface, AccountInterface, ModuleHandler

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 google_analitycs-drupal_dependency_injection-3010797.patch10.2 KBthalles

Comments

Thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new google_analitycs-drupal_dependency_injection-3010797.patch10.2 KB

Hi, Congratulations on the module!
Here is the patch that injects dependencies.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
hass’s picture

hass commented
Version: 8.x-2.x-dev » 8.x-3.x-dev

Thanks. Please also roll for 3.x

  • hass committed 602307e on 8.x-3.x authored by Thalles 
    Issue #3010797 by Thalles: Drupal dependency injection

  • hass committed 03d56d4 on 8.x-2.x authored by Thalles 
    Issue #3010797 by Thalles: Drupal dependency injection
hass’s picture

hass commented
Status: Needs review » Fixed

Also ported to Matomo Admin Form.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

I will do

hass’s picture

hass commented

All done...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.