There is an "Only show errors" checkbox option on configuration listing page at /admin/reports/config-inspector. Checking this option will only show schema with the errors. This checkbox label has a missing for attribute which does not make the label clickable. Adding this missing attribute will make the label clickable.

CommentFileSizeAuthor
#8 config_inspector_3009614-8.patch586 bytesdhirendra.mishra
#6 config_inspector_3009614-6.patch491 bytesdhirendra.mishra
#5 config_inspector_3009614-5.patch491 bytesdhirendra.mishra

Comments

msankhala created an issue. See original summary.

msankhala’s picture

msankhala commented
Title: Add missing for attribute to "Only show errors" checkbox label » Add missing "for" attribute to "Only show errors" checkbox label
msankhala’s picture

msankhala commented
Issue summary: View changes
dhirendra.mishra’s picture

dhirendra.mishra commented
Assigned: Unassigned » dhirendra.mishra
Status: Active » Needs work

Working on it.

dhirendra.mishra’s picture

dhirendra.mishra commented
Assigned: dhirendra.mishra » Unassigned
Status: Needs work » Needs review
StatusFileSize
new config_inspector_3009614-5.patch491 bytes

Here is the patch.

dhirendra.mishra’s picture

dhirendra.mishra commented
StatusFileSize
new config_inspector_3009614-6.patch491 bytes

Ignore above patch.Here is the correct one.

dhirendra.mishra’s picture

dhirendra.mishra commented
Assigned: Unassigned » dhirendra.mishra
Status: Needs review » Needs work

Needs to add Attribute to label not on input type. So working on it.

dhirendra.mishra’s picture

dhirendra.mishra commented
Assigned: dhirendra.mishra » Unassigned
Status: Needs work » Needs review
StatusFileSize
new config_inspector_3009614-8.patch586 bytes

Here is the updated patch.Kindly test and review it.

msankhala’s picture

msankhala commented
Status: Needs review » Reviewed & tested by the community

@dhirendra.mishra Nice work. LGTM.

  • Gábor Hojtsy committed 2ed7c9f on 8.x-1.x 
    Issue #3009614 by dhirendra.mishra, msankhala: Add missing "for"...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.