Basically getting a fatal PHP error when trying to install in Drupal 8.6.2

Full error is

Error: Call to undefined function variable_get() in beautytips_textinput_form_change() (line 60 of modules/contrib/beautytips/includes/textinput.inc).

I'm just a bit confused how this ever worked in D8 with variable_get() and whether I'm looking at the right version.

Comments

NicolasH created an issue. See original summary.

pifagor’s picture

Issue tags: +epam-contrib-2018
artemboiko’s picture

Assigned: Unassigned » artemboiko
driverok’s picture

Assigned: artemboiko » Unassigned
Status: Active » Needs review
StatusFileSize
new0 bytes

variable_get() occurences replaced by \Drupal::state()->get()
Please review.

driverok’s picture

StatusFileSize
new0 bytes

Sorry, forget to upload a file.
Please review patch #5.

driverok’s picture

StatusFileSize
new6.75 KB

Sorry again, some local issue with a filesystem.
Actual patch is #6.
Please review.

Raman Starshykh’s picture

Assigned: Unassigned » Raman Starshykh
Raman Starshykh’s picture

Successfully tested in 1.x-dev version.
Module BeautyTips UI successfully installed.

Raman Starshykh’s picture

Assigned: Raman Starshykh » Unassigned
Status: Needs review » Reviewed & tested by the community
pifagor’s picture

  • pifagor committed 9ffdbcb on 8.x-1.x authored by driverok
    Issue #3009416 by driverok, Raman Starshykh, NicolasH, pifagor: Call to...
pifagor’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

alex_optim’s picture

Patch work for me.

pifagor’s picture